Integrate PVC creation feature using snapshot to replication controller for single cluster

[YichenYa0]

Description

• This feature extends the existing repctl / replication controller from just creating snapshots to also creating PVCs necessary to start a test copy of the application. For single cluster the test copy of the application must be started in a different namespace than the production copy of the application which is assumed to be running.
• This uses the replication action to take a snapshot of the target volume(s), and is applied to all volumes in the replication group
• PVC/PV pairs are created in the namespace of the VolumeSnapshots taken
• The user can start a new copy of the original application using the replicated objects by specifying the new namespace of the created PVC/PV pairs

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
N/A

Checklist:

• I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
• I have verified that new and existing unit tests pass locally with my changes
• I have not allowed coverage numbers to degenerate
• I have maintained at least 90% code coverage
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• I have maintained backward compatibility

How Has This Been Tested?

• Manual test using replication action
• Unit testing
• Integrated testing

Manual Testing Instruction

• Rebuild repctl
• The user has the option to specify the snapshot class in the replication action they provide: repctl snapshot --rg rg-id --sn-class vxflexos-snapclass-delete --sn-namespace test-delete --create-pvcs --storage-class vxflexos-217
• The user also has the option not to specify a snapshot class in the replication action, and a sufficient default class will automatically be supplied or created if it does not already exist: repctl snapshot --rg rg-id --sn-namespace test-default --create-pvcs --storage-class vxflexos-217
• Deploy an app, but update helm chat to specify namespace of newly created PVC/PV (e.g. test-pg1)
• Tested on both single and multi cluster.

Test Coverage Change

/controllers/replication-controller/dellcsireplicationgroup_controller.go change:

Original test coverage of main branch	Latest test coverage due to added code
58.4%	84.0%

[santhoshatdell]

Is this PR ready for review? It's in draft state.

[lukeatdell]

The example and the implementation do not match.
Not a big deal, but if you're making any other changes, maybe update here as well.

[lukeatdell]

I think, in the other PR, there were more concise consts for these array indexes.
Can we update here as well if they exist?

[lukeatdell]

Suggested change

	if createPVCtrue {
	rg.Annotations[prefix+"/snapshotCreatePVC"] = "true"
	} else {
	rg.Annotations[prefix+"/snapshotCreatePVC"] = "false"
	}
	rg.Annotations[prefix+"/snapshotCreatePVC"] = createPVCtrue

Additionally, maybe rename createPVCtrue to createPVC to avoid confusion?

[santhoshatdell]

Moving to Draft state, need to check with POs regarding this feature's milestone.