Skip to content

Commit

Permalink
Update linters.yaml (#127)
Browse files Browse the repository at this point in the history
  • Loading branch information
gallacher authored May 15, 2024
1 parent bd27bdd commit 947d54b
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/linters.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@ jobs:
- name: golangci-lint
uses: golangci/golangci-lint-action@v4
with:
version: v1.53
version: latest
skip-cache: true
4 changes: 2 additions & 2 deletions inttests/replication_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ func (suite *ReplicationTestSuite) TearDownSuite() {
suite.T().Fail()
}
C.ModifyVolumeGroup(context.Background(), &gopowerstore.VolumeGroupModify{ProtectionPolicyID: ""}, suite.vg.ID)
C.RemoveMembersFromVolumeGroup(context.Background(), &gopowerstore.VolumeGroupMembers{VolumeIds: []string{suite.vol.ID}}, suite.vg.ID)
C.RemoveMembersFromVolumeGroup(context.Background(), &gopowerstore.VolumeGroupMembers{VolumeIDs: []string{suite.vol.ID}}, suite.vg.ID)
C.ModifyVolume(context.Background(), &gopowerstore.VolumeModify{ProtectionPolicyID: ""}, suite.vol.ID)
C.DeleteProtectionPolicy(context.Background(), suite.pp.ID)
C.DeleteReplicationRule(context.Background(), suite.rr.ID)
Expand Down Expand Up @@ -107,7 +107,7 @@ func getRemoteSystem(t *testing.T, suite *ReplicationTestSuite) (string, string)

suite.pp, err = C.CreateProtectionPolicy(context.Background(), &gopowerstore.ProtectionPolicyCreate{
Name: "intcsi" + suite.randomString + "-pptst",
ReplicationRuleIds: []string{suite.rr.ID},
ReplicationRuleIDs: []string{suite.rr.ID},
})

if err == nil {
Expand Down
2 changes: 1 addition & 1 deletion replication_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ func TestClientIMPL_CreateProtectionPolicy(t *testing.T) {
createReq := ProtectionPolicyCreate{
Name: "pp-test",
Description: "pp-test",
ReplicationRuleIds: []string{"id"},
ReplicationRuleIDs: []string{"id"},
}

resp, err := C.CreateProtectionPolicy(context.Background(), &createReq)
Expand Down
4 changes: 2 additions & 2 deletions replication_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,9 @@ type ProtectionPolicyCreate struct {
// Policy description.
Description string `json:"description,omitempty"`
// IDs of replication rules
ReplicationRuleIds []string `json:"replication_rule_ids"`
ReplicationRuleIDs []string `json:"replication_rule_ids"`
// IDs of snapshot rules
SnapshotRuleIds []string `json:"snapshot_rule_ids"`
SnapshotRuleIDs []string `json:"snapshot_rule_ids"`
}

// failover params create failover request
Expand Down
4 changes: 2 additions & 2 deletions volume_group_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ func TestClientIMPL_CreateVolumeGroup(t *testing.T) {
Name: "vg-test",
Description: "vg-test",
ProtectionPolicyID: volID,
VolumeIds: []string{volID2},
VolumeIDs: []string{volID2},
}

resp, err := C.CreateVolumeGroup(context.Background(), &createReq)
Expand Down Expand Up @@ -224,7 +224,7 @@ func TestClientIMPL_RemoveMembersFromVolumeGroup(t *testing.T) {
httpmock.NewStringResponder(201, respData))

createReq := VolumeGroupMembers{
VolumeIds: []string{"id-1", "id-2"},
VolumeIDs: []string{"id-1", "id-2"},
}

resp, err := C.RemoveMembersFromVolumeGroup(context.Background(), &createReq, volID)
Expand Down
4 changes: 2 additions & 2 deletions volume_group_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ type VolumeGroupCreate struct {
// All the volumes must be on the same Cyclone appliance and should not be part of another volume group.
// If a list of volumes is not specified or if the specified list is empty, an
// empty volume group of type Volume will be created.
VolumeIds []string `json:"volume_ids,omitempty"`
VolumeIDs []string `json:"volume_ids,omitempty"`
}

// VolumeGroup details about a volume groups.
Expand Down Expand Up @@ -98,7 +98,7 @@ type VolumeGroups struct {
}

type VolumeGroupMembers struct {
VolumeIds []string `json:"volume_ids"`
VolumeIDs []string `json:"volume_ids"`
}

// VolumeGroupModify modifies existing Volume Group
Expand Down

0 comments on commit 947d54b

Please sign in to comment.