Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added API to GetNVMeTCP targets #122

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Added API to GetNVMeTCP targets #122

merged 3 commits into from
Jan 23, 2024

Conversation

delldubey
Copy link
Contributor

PR Submission checklist

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1108

Common PR Checklist:

  • Have you made sure that the code compiles?
  • Have you commented your code, particularly in hard-to-understand areas
  • Did you run tests in a real Kubernetes cluster?
  • Have you maintained backward compatibility

Description of your changes:

  • Added GetNVMeTCP targets to get details

shanmydell
shanmydell previously approved these changes Jan 23, 2024
View reviewed changes
adarsh-dell
adarsh-dell reviewed Jan 23, 2024
View reviewed changes
ip_pool_address.go Outdated Show resolved Hide resolved
adarsh-dell
adarsh-dell approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@adarsh-dell adarsh-dell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

nidtara
nidtara approved these changes Jan 23, 2024
View reviewed changes
Copy link

@nidtara nidtara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boyamurthy boyamurthy merged commit ec40aaf into main Jan 23, 2024
4 checks passed
@shanmydell shanmydell deleted the nvme_tcp branch January 31, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adarsh-dell adarsh-dell adarsh-dell approved these changes

@nidtara nidtara nidtara approved these changes

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell AkshaySainiDell is a code owner

@boyamurthy boyamurthy Awaiting requested review from boyamurthy

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell

@francis-nijay francis-nijay Awaiting requested review from francis-nijay

@gilltaran gilltaran Awaiting requested review from gilltaran

@harishp8889 harishp8889 Awaiting requested review from harishp8889

@harshitap26 harshitap26 Awaiting requested review from harshitap26

@kenivi1 kenivi1 Awaiting requested review from kenivi1

@niranjan-n1 niranjan-n1 Awaiting requested review from niranjan-n1

@prablr79 prablr79 Awaiting requested review from prablr79

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell santhoshatdell is a code owner

@satyakonduri satyakonduri Awaiting requested review from satyakonduri

@santhoshhs10 santhoshhs10 Awaiting requested review from santhoshhs10

@suryagupta4 suryagupta4 Awaiting requested review from suryagupta4

@tssushma tssushma Awaiting requested review from tssushma

@shanmydell shanmydell Awaiting requested review from shanmydell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@delldubey @shanmydell @nidtara @adarsh-dell @boyamurthy