Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit tests #126

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Fix unit tests #126

merged 3 commits into from
Feb 27, 2024

Conversation

atye
Copy link
Contributor

@atye atye commented Feb 26, 2024

PR Submission checklist

Fix Client unit tests by using api.ContextKey type.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1091

Common PR Checklist:

  • Have you made sure that the code compiles?
  • Have you commented your code, particularly in hard-to-understand areas
  • Did you run tests in a real Kubernetes cluster?
  • Have you maintained backward compatibility

Description of your changes:

Use api.ContextKey type.

KerryKovacevic
KerryKovacevic previously approved these changes Feb 26, 2024
Copy link
Contributor

@delldubey delldubey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boyamurthy boyamurthy merged commit bd27bdd into main Feb 27, 2024
3 of 4 checks passed
@atye atye deleted the fix-unit-test branch February 27, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants