Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused RESTAPI code related to register k8s cluster #129

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Remove unused RESTAPI code related to register k8s cluster #129

merged 2 commits into from
Jun 25, 2024

Conversation

suryagupta4
Copy link
Contributor

@suryagupta4 suryagupta4 commented Jun 21, 2024 •
edited
Loading

PR Submission checklist

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1317

Common PR Checklist:

  • Have you made sure that the code compiles?
  • Have you commented your code, particularly in hard-to-understand areas
  • Did you run tests in a real Kubernetes cluster?
  • Have you maintained backward compatibility

Description of your changes:

Remove unused RESTAPI code related to register k8s cluster

make unit-test

image

@suryagupta4 suryagupta4 self-assigned this Jun 21, 2024
@suryagupta4 suryagupta4 marked this pull request as ready for review June 24, 2024 17:25
AkshaySainiDell
AkshaySainiDell previously approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@AkshaySainiDell AkshaySainiDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adarsh-dell
Copy link
Contributor

@suryagupta4 Can you please update the copyright year?

adarsh-dell
adarsh-dell previously approved these changes Jun 25, 2024
View reviewed changes
@suryagupta4 suryagupta4 dismissed stale reviews from adarsh-dell and AkshaySainiDell via 5257d99 June 25, 2024 05:10
@suryagupta4 suryagupta4 merged commit 24d3bd8 into main Jun 25, 2024
4 checks passed
@suryagupta4 suryagupta4 deleted the bug-1317-remove-unused-code branch June 25, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adarsh-dell adarsh-dell adarsh-dell approved these changes

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@boyamurthy boyamurthy Awaiting requested review from boyamurthy

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell

@delldubey delldubey Awaiting requested review from delldubey

@francis-nijay francis-nijay Awaiting requested review from francis-nijay

@gilltaran gilltaran Awaiting requested review from gilltaran

@harishp8889 harishp8889 Awaiting requested review from harishp8889

@harshitap26 harshitap26 Awaiting requested review from harshitap26

@kenivi1 kenivi1 Awaiting requested review from kenivi1

@niranjan-n1 niranjan-n1 Awaiting requested review from niranjan-n1

@prablr79 prablr79 Awaiting requested review from prablr79

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell santhoshatdell is a code owner

@satyakonduri satyakonduri Awaiting requested review from satyakonduri

@santhoshhs10 santhoshhs10 Awaiting requested review from santhoshhs10

@shanmydell shanmydell Awaiting requested review from shanmydell

@tssushma tssushma Awaiting requested review from tssushma

Assignees

@suryagupta4 suryagupta4

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suryagupta4 @adarsh-dell @AkshaySainiDell