Metro volume configure/end #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactoring MetroConfig and MetroSessionId type for compatibility with json decoder. - refactoring tests to match types. - fixing asser.Equal implementations to put correct variables in "expected" and "actual" arguments.
- updating configure-metro tests to end metro before deleting test vols.
- modifying tests to get new clients before testing in order to create a clean testing environments
- Suite setup will get all remote systems and iterate over them, trying to find one with Metro capabilities and in good connected state - Removed previous need for env GOPOWERSTORE_REMOTE_NAME
lukeatdell
requested review from
adarsh-dell,
AkshaySainiDell,
boyamurthy,
ChristianAtDell,
delldubey and
francis-nijay
as code owners
lukeatdell
requested review from
gilltaran,
harishp8889,
harshitap26,
kenivi1,
niranjan-n1,
prablr79,
santhoshatdell,
satyakonduri,
santhoshhs10,
shanmydell,
suryagupta4 and
tssushma
as code owners
santhoshatdell
previously approved these changes
Sep 5, 2024
santhoshatdell
approved these changes
Sep 5, 2024
donatwork
approved these changes
Sep 5, 2024
| if err != nil { | ||
| log.Printf("%s file not found.", envVarsFile) | ||
| } | ||
| client, err = gopowerstore.NewClient() |
There was a problem hiding this comment.
Does NewClient use the session tokens if already logged into the array?
There was a problem hiding this comment.
I believe, based on a quick review, the client will get a new token for each new client.
santhoshatdell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding support for
volumeendpoint actions,configure_metroandend_metroto configure and end metro replication at a volume level.configure_metroandend_metro.ReplicationSessionstruct to support the sessiontype.RemoteSystemstruct to supportdata_connection_stateandcapabilities.GitHub Issues
List the GitHub issues impacted by this PR:
Common PR Checklist:
Testing
Integration Tests
Main
compute_differencestest was failing due to reuse of API client between tests.This PR
Unit Tests
Main
Tests were failing due to a missed update to json field that was changed from
volume_grouptovolume_groups.This PR