adding replication rule modify function #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shenda1 <[email protected]>
shenda1
requested review from
abhi16394,
adarsh-dell,
AkshaySainiDell,
donatwork,
lukeatdell and
santhoshatdell
as code owners
Signed-off-by: shenda1 <[email protected]>
|
LGTM. Please take approval from @AkshaySainiDell @donatwork @santhoshatdell .... |
|
@shenda1 Please generate mock for the new method. |
donatwork
previously approved these changes
Dec 13, 2024
Signed-off-by: shenda1 <[email protected]>
Hi @AkshaySainiDell The modify function does not return any response apart from status code. Please find below screenshot. |
Signed-off-by: shenda1 <[email protected]>
Signed-off-by: shenda1 <[email protected]>
santhoshatdell
approved these changes
Dec 13, 2024
donatwork
approved these changes
Dec 13, 2024
AkshaySainiDell
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission checklist
GitHub Issues
List the GitHub issues impacted by this PR:
Common PR Checklist:
Description of your changes:
PR is raised to add modify functionality for replication rule. Also, the ReplicationRuleCreate is enhanced to support optional params during create operation. Tested with unit test. Please find below screenshot.