Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade CODEOWNERS and package dependencies #250

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Upgrade CODEOWNERS and package dependencies #250

merged 2 commits into from
Nov 7, 2023

Conversation

shaynafinocchiaro
Copy link
Collaborator

Description

PR update CODEOWNERS and to use latest package dependencies.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1012

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit test

KerryKovacevic
KerryKovacevic previously approved these changes Nov 6, 2023
View reviewed changes
xuluna
xuluna reviewed Nov 6, 2023
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
@shaynafinocchiaro
Copy link
Collaborator Author

run e2e test

@shaynafinocchiaro shaynafinocchiaro merged commit 3da34e2 into main Nov 7, 2023
@shaynafinocchiaro shaynafinocchiaro deleted the update-dependencies branch November 7, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alikdell alikdell alikdell approved these changes

@xuluna xuluna xuluna approved these changes

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@EvgenyUglov EvgenyUglov Awaiting requested review from EvgenyUglov EvgenyUglov is a code owner

@bjiang27 bjiang27 Awaiting requested review from bjiang27 bjiang27 is a code owner

@IsaiasA1 IsaiasA1 Awaiting requested review from IsaiasA1

@aqu-dell aqu-dell Awaiting requested review from aqu-dell

@KerryKovacevic KerryKovacevic Awaiting requested review from KerryKovacevic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shaynafinocchiaro @xuluna @alikdell @KerryKovacevic