Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update linter go version #264

Merged
merged 10 commits into from
Feb 23, 2024
Merged

update linter go version #264

merged 10 commits into from
Feb 23, 2024

Conversation

cbartoszDell
Copy link
Contributor

@cbartoszDell cbartoszDell commented Feb 8, 2024

  • Update of go version in linter action.
  • Remove gosec from linter. gosec is already being run in the go_security_scan. This is to avoid G402: TLS InsecureSkipVerify set true. (gosec) linter error
  • Adds make lint for automating linting fixes, when possible

@csmbot
Copy link
Collaborator

csmbot commented Feb 8, 2024

Can one of the admins verify this patch?

donatwork
donatwork previously approved these changes Feb 13, 2024
@shaynafinocchiaro shaynafinocchiaro dismissed their stale review February 13, 2024 16:36

@cbartoszDell Linting issues were addressed in an earlier PR #257. This is a regression.

@cbartoszDell
Copy link
Contributor Author

This PR is only for upgrading the versions on Go and golangci-lint action. This is required to make sure that golangci-lint is always the latest version and is working with the latest version of Go. This requests is being made to all CSM drivers and modules to make sure linter action keeps working. Fixing linter warnings is not a part of scope of this upgrade PR.

xuluna
xuluna previously approved these changes Feb 22, 2024
KerryKovacevic
KerryKovacevic previously approved these changes Feb 22, 2024
atye
atye previously approved these changes Feb 22, 2024
Copy link
Contributor

@shefali-malhotra shefali-malhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaynafinocchiaro
Copy link
Collaborator

run e2e test

@shaynafinocchiaro shaynafinocchiaro merged commit 2214b85 into main Feb 23, 2024
8 checks passed
@shaynafinocchiaro shaynafinocchiaro deleted the linter-go branch February 23, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants