Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows OS for release builds #101

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Add Windows OS for release builds #101

merged 1 commit into from
Dec 20, 2023

Conversation

nikitajoshi1
Copy link
Contributor

@nikitajoshi1 nikitajoshi1 commented Dec 20, 2023 •
edited
Loading

Description

Add Windows OS for release builds as we need to support that too for upcoming releases.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Acceptance tests

gokul-srivathsan
gokul-srivathsan approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@gokul-srivathsan gokul-srivathsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shenda1 shenda1 merged commit ecae212 into main Dec 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doriac11 doriac11 doriac11 approved these changes

@gokul-srivathsan gokul-srivathsan gokul-srivathsan approved these changes

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell Sakshi-dell is a code owner

@prajwalpatil25 prajwalpatil25 Awaiting requested review from prajwalpatil25

@shenda1 shenda1 Awaiting requested review from shenda1 shenda1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nikitajoshi1 @gokul-srivathsan @doriac11 @shenda1