Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added file system resource #123

Merged
merged 12 commits into from
Jan 6, 2025
Merged

added file system resource #123

merged 12 commits into from
Jan 6, 2025

Conversation

AnikaAgiwal2711
Copy link
Collaborator

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Acceptance tests

@AnikaAgiwal2711 AnikaAgiwal2711 mentioned this pull request Dec 20, 2024
Merged
4 tasks
shenda1
shenda1 reviewed Dec 23, 2024
View reviewed changes
models/filesystem.go Outdated Show resolved Hide resolved
shenda1
shenda1 reviewed Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@shenda1 shenda1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add coverage report

@AnikaAgiwal2711
Copy link
Collaborator Author

image

@Sakshi-dell Sakshi-dell merged commit 1fe490e into main Jan 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sakshi-dell Sakshi-dell Sakshi-dell approved these changes

@shenda1 shenda1 shenda1 approved these changes

@doriac11 doriac11 Awaiting requested review from doriac11 doriac11 is a code owner

@shekhar-j shekhar-j Awaiting requested review from shekhar-j shekhar-j is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AnikaAgiwal2711 @shenda1 @Sakshi-dell