added filesystem snapshot datasource #127
Conversation
Krishnan-Priyanshu
requested review from
Sakshi-dell,
shenda1,
doriac11 and
shekhar-j
as code owners
|
run e2e test HostGroupDs |
|
run e2e test HostGroupDs |
|
|
|
run e2e test FileSystemSnapshotDs |
| Optional: true, | ||
| Validators: []validator.String{ | ||
| stringvalidator.LengthAtLeast(1), | ||
| stringvalidator.ConflictsWith(path.MatchRoot("id"), path.MatchRoot("name")), |
There was a problem hiding this comment.
I think check is not needed since it already added to other 2 attributes
| }, | ||
| }, | ||
| "filesystems": schema.ListNestedAttribute{ | ||
| Description: "List of File System.", |
|
we can added the latest commit in go.mod |
|
run e2e test FileSystemSnapshotDs |
|
|
||
| This datasource is used to query the existing File System Snapshot from PowerStore array. The information fetched from this datasource can be used for getting the details for further processing in resource block. | ||
|
|
||
| > **Note:** Only one of `name` or `id` or `filesystem_id` can be provided at a time. |
There was a problem hiding this comment.
This description seems outdated. Same in file_system daatasource.
| } | ||
|
|
||
| data "powerstore_filesystem_snapshot" "test1" { | ||
| name = resource.powerstore_filesystem_snapshot.test.name |
There was a problem hiding this comment.
Datasource examples are not given with resource prereqs since users will probably never write any code like this. Datasource examples can have datasource prereqs (eg. filesystem datasource prereq for filesystem_snapshot daatsource).
Only resource examples use resource or datasource prereqs, covering probable common scenarios.
There was a problem hiding this comment.
Also, better give an example with nas_server_id
Description
A few sentences describing the overall goals of the pull request's commits.
File System Snapshot Datasource
Test Run
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration