-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AsyncValidationCE binding against asyncResult #260
Fix AsyncValidationCE binding against asyncResult #260
Conversation
…ary Result qualifiers
@TheAngryByrd assuming build server works fine, I think this is good to look at again. I believe I fixed the issue mentioned above and noticed I didn't even include the task bindings initially. I went ahead and added those along with cleaning up some unnecessary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing it up! Left some feedback.
@TheAngryByrd ready again when you have time 😁 |
- [Fix AsyncValidationCE binding against asyncResult](#260) Credits @1eyewonder
- [Fix AsyncValidationCE binding against asyncResult](#260) Credits @1eyewonder
Proposed Changes
Refactored the AsyncValidationCE source overloads to fix the issue seen in the last Amplifying F# video where AsyncResults were not binding correctly
Types of changes
What types of changes does your code introduce to FsToolkit.ErrorHandling?
Put an
x
in the boxes that apply and remove ones that don't applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments