Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AsyncValidationCE binding against asyncResult #260

Conversation

1eyewonder
Copy link
Contributor

Proposed Changes

Refactored the AsyncValidationCE source overloads to fix the issue seen in the last Amplifying F# video where AsyncResults were not binding correctly

Types of changes

What types of changes does your code introduce to FsToolkit.ErrorHandling?
Put an x in the boxes that apply and remove ones that don't apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

⚠️ Please sanity check me. I think I updated a test case correctly, but because I am modifying a previous test case, I would appreciate a second set of eyes on this

@1eyewonder
Copy link
Contributor Author

@TheAngryByrd assuming build server works fine, I think this is good to look at again. I believe I fixed the issue mentioned above and noticed I didn't even include the task bindings initially. I went ahead and added those along with cleaning up some unnecessary Result namespace qualifiers. Let me know if you want anything done differently and sorry for such a long delay!

Copy link
Collaborator

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it up! Left some feedback.

tests/FsToolkit.ErrorHandling.Tests/AsyncValidationCE.fs Outdated Show resolved Hide resolved
tests/FsToolkit.ErrorHandling.Tests/AsyncValidationCE.fs Outdated Show resolved Hide resolved
tests/FsToolkit.ErrorHandling.Tests/AsyncValidationCE.fs Outdated Show resolved Hide resolved
tests/FsToolkit.ErrorHandling.Tests/AsyncValidationCE.fs Outdated Show resolved Hide resolved
tests/FsToolkit.ErrorHandling.Tests/AsyncValidationCE.fs Outdated Show resolved Hide resolved
@1eyewonder
Copy link
Contributor Author

@TheAngryByrd ready again when you have time 😁

@TheAngryByrd TheAngryByrd merged commit 8f2f654 into demystifyfp:master May 2, 2024
25 checks passed
@TheAngryByrd TheAngryByrd changed the title Refactor AsyncValidationCE module for bugfix Fix AsyncValidationCE binding against asyncResult May 2, 2024
TheAngryByrd added a commit that referenced this pull request May 2, 2024
- [Fix AsyncValidationCE binding against asyncResult](#260) Credits @1eyewonder
TheAngryByrd added a commit that referenced this pull request May 2, 2024
- [Fix AsyncValidationCE binding against asyncResult](#260) Credits @1eyewonder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants