Fix some issues with tables

denismaitak · Jun 27, 2023 · 9ab4b2e · 9ab4b2e
1 parent 640b1db
commit 9ab4b2e
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 6 deletions.
diff --git a/src/jira_report_generator/tables/assignees.py b/src/jira_report_generator/tables/assignees.py
@@ -90,6 +90,9 @@ def _generate_row(name, df, components, estimate, spent, **attrs) -> TR:
         rows.append(row)
         scrollable_rows.append(scollable_row)
 
+    if not components:
+        return Table(rows, **table_options)
+
     return Div(
         Div(
             Table(rows, **table_options),

diff --git a/src/jira_report_generator/tables/epics.py b/src/jira_report_generator/tables/epics.py
@@ -8,6 +8,7 @@ def generate_epics_table(df: DataFrame, **table_options: str):
     rows = []
     header = TR()
     epics = df[df["type"].apply(lambda x: x.name == "Epic")]
+    epics_list = list(epics.iterrows())
     completed_statuses = (
         Status.CLIENT_REVIEW.value,
         Status.COMPLETED.value,
@@ -30,7 +31,7 @@ def generate_epics_table(df: DataFrame, **table_options: str):
 
     rows.append(header)
 
-    for _, epic in epics.iterrows():
+    for _, epic in epics_list:
         row = TR(**{"data-epic-id": epic.id})
         epic_tasks = df[df["parent"].apply(
             lambda x: x is not None and x.id == epic.id
@@ -65,4 +66,7 @@ def generate_epics_table(df: DataFrame, **table_options: str):
 
         rows.append(row)
 
+    if not epics_list:
+        rows = []
+
     return Table(rows, **table_options)
diff --git a/src/jira_report_generator/tables/statuses.py b/src/jira_report_generator/tables/statuses.py
@@ -101,6 +101,9 @@ def _generate_row(name, df, components, estimate, spent, **attrs) -> TR:
     rows.append(footer_row)
     scrollable_rows.append(footer_scrollable_row)
 
+    if not components:
+        return Table(rows, **table_options)
+
     return Div(
         Div(
             Table(rows, **table_options),

diff --git a/src/jira_report_generator/tables/versions.py b/src/jira_report_generator/tables/versions.py
@@ -41,11 +41,11 @@ def generate_component_columns(
 
         # generate empty columns
         if component_tasks.empty:
-            columns.append(TD())
-            columns.append(TD())
-            columns.append(TD())
-            columns.append(TD())
-            columns.append(TD())
+            columns.append(TD("&nbsp;"))
+            columns.append(TD("&nbsp;"))
+            columns.append(TD("&nbsp;"))
+            columns.append(TD("&nbsp;"))
+            columns.append(TD("&nbsp;"))
             continue
 
         component_estimate = round(
@@ -271,6 +271,9 @@ def generate_versions_table(
 
     rows.append(row)
 
+    if not components:
+        return Table(rows, **table_options)
+
     return Div(
         Div(
             Table(rows, **table_options),

diff --git a/src/jira_report_generator/utils/tags.py b/src/jira_report_generator/utils/tags.py
@@ -64,6 +64,9 @@ def __str__(self):
         self.value = "".join(map(str, self.rows))
         return super().__str__()
 
+    def __bool__(self):
+        return bool(self.rows)
+
     def append(self, row: TR):
         self.rows.append(row)
 
@@ -80,5 +83,8 @@ def __str__(self):
         self.value = "".join(map(str, self.elements))
         return super().__str__()
 
+    def __bool__(self):
+        return bool(self.elements)
+
     def append(self, element):
         self.rows.append(element)