feat: introduce KillSignal for sending signals to tasks
#131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
changed the title
KillSignal for sending signals to tasks
bartlomieju
approved these changes
Nov 28, 2024
| #[tokio::test] | ||
| async fn listens_for_signals() { | ||
| if cfg!(windows) { | ||
| return; // signals are terrible on windows |
littledivy
reviewed
Nov 28, 2024
src/shell/commands/executable.rs
Outdated
Comment on lines
77
to
78
| let _ = child.kill().await; | ||
| return ExecuteResult::Continue(signal.aborted_code(), Vec::new(), Vec::new()); |
There was a problem hiding this comment.
Should we return the ExecuteResult with aborted code returned by child.kill() instead?
Yes, I think so. |
…ertain tree of execution
dsherret
commented
Nov 28, 2024
| TestBuilder::new() | ||
| .command(r#"deno eval 'Deno.addSignalListener("SIGINT", () => { console.log("interrupted!"); setTimeout(() => Deno.exit(0), 25); }); setInterval(() => {}, 1000)'"#) | ||
| .kill_signal(kill_signal) | ||
| .assert_exit_code(0) // signal was handled and a `Deno.exit(0)` was done |
There was a problem hiding this comment.
I improved the handling to return 0 in this case, which makes more sense because the signal was handled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more advanced and appropriate form of a cancellation token.
For #33