-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leaf 4486 - user name disabled update #2644
Open
jampaul3
wants to merge
12
commits into
dev
Choose a base branch
from
enhancement/Leaf-4486/userName_disabled_update
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jampaul3
requested review from
mgaoVA,
Pelentan,
aerinkayne,
pete-nerantzinis,
shaneodd and
nk2136
as code owners
January 9, 2025 16:22
shaneodd
requested changes
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the refreshOrgchart, I would put a message of why it is exiting. Or remove the file all together if we are not using it.
@shaneodd I removed the exit. I did that so I could easily stop the cron jobs. This is now back to normal. |
Pelentan
previously approved these changes
Jan 17, 2025
Pelentan
previously approved these changes
Jan 21, 2025
shaneodd
previously approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The old script, which resides on the Auth server processed all Active Directory updates to Leaf. Now the Auth Server will get the data from AD and save it to a table (cache) in the National Orgchart. Then a cron job on Leaf servers runs to update Employee data in the national orgchart. After this update is complete another script runs to disable Employees that have not been updated within the last 30 hours.
For the purposes of this PR an Employee is considered disabled if their record in the National Orgchart hasn't been updated within the last 30 hours. Every Employee has a lastUpdated field and this gets updated whenever the script runs to update Employees whether or not they had data to be updated, if it hasn't been updated they were not pulled from AD which means that userName is no longer being used and needs to be disabled.
There is also a fail safe when updating disabled Employees, the script looks to make sure that at least 200k Employee's have been updated within the last 2 hours before attempting to disable anyone.