LEAF 4625 - history/approval info #2659
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add db file, add class properties for system and nonworkflow actions. Update queries. Add step id to list of active actions in WF editor.
aerinkayne
requested review from
mgaoVA,
pete-nerantzinis,
Pelentan,
shaneodd,
jampaul3 and
nk2136
jampaul3
previously approved these changes
Jan 22, 2025
Pelentan
requested changes
Jan 22, 2025
| $vars = array( | ||
| ':nonWorkflowActions' => implode(",", $this->nonWorkflowActions) | ||
| ); | ||
| $qSQL = "SELECT * FROM actions WHERE NOT FIND_IN_SET(actionType, :nonWorkflowActions) AND deleted=0 ORDER BY actionText"; |
There was a problem hiding this comment.
Two things. Do you need the select *, and is an index being used?
| $vars = array( | ||
| ':systemAction' => implode(",", $this->systemAction) | ||
| ); | ||
| $qSQL = "SELECT * FROM actions WHERE NOT FIND_IN_SET(actionType, :systemAction) AND NOT (deleted = 1)"; |
Pelentan
approved these changes
Jan 22, 2025
jampaul3
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a request initiator is changed, a request step is changed, or a request is cancelled, the Request History modal displays
'Action by username'. Step change and initiator change include additional comments to clarify the action. Cancel does not, which makes what has occurred unclear. In the report builder, the approval history displays as 'null' for these changes.
This update adds 'move', 'changeInitiator', and 'deleted' actionTypes and associated text to the actions table.
These actionType names correspond to the entries that are already added to the actions_history table.
Prod was queried for existing custom workflow actions. One active 'Move' actiontype was found and updated to MoveRequest.
Impact / Testing
Request History modal should show the below information on initiator change, step move and cancel
Action: Change Initiator by username
Action: Change Step by username
Action: Cancel by username
Report Builder (approval history) should show below information instead of 'null'
Changed Initiator
Changed Step
Cancelled
Workflow Editor -> Edit Actions
The Built-In actions below should not show in the Actions Editor
'approve', 'concur', 'defer', 'disapprove', 'sendback', 'submit', 'sign', 'deleted', 'changeInitiator', 'move'
Workflow Editor -> Connect two steps
The Create New Workflow Action modal should not include the actions with actionTypes 'move', 'deleted', 'changeInitiator'.