Fully corrects Parentheses Issue in Lookup table build #3972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results102 tests 102 ✅ 16s ⏱️ Results for commit b800151. ♻️ This comment has been updated with latest results. |
JaCoCo Test Coverage
|
CorySohrakoffUSDS
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This is a larger fix for the bugfix in #3969. Before this PR, parenthetical terms were included as individual terms in the lookup table and for some terms this provided incorrect classifications. #3969 only removed these terms from the list, but a larger fix would be to include a way that we can correctly classify these terms.
Associated tickets or Slack threads:
How does this fix it?1
This fix will include the body part with the parenthetical term to ensure proper classification. Example:
term: degenerative arthritis (osteoarthritis) in wrist, left" will create following lookup options:
Separating out the options in this manner will allow us to correctly classify this term.
How to test this PR
Footnotes
Pull-Requests guidelines. If PR is significant, update Current Software State wiki page. ↩