Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - Sev-3 - All - Alert component has duplicate heading accessibility roles when not expandable #620

Open
4 tasks done
oddballdave opened this issue Jan 14, 2025 · 1 comment · May be fixed by #621
Open
4 tasks done
Assignees
Labels
accessibility Accessibility awareness or needs for the ticket design-system DS-Bug Bug tickets specifically for the Design System front-end Ticket requires front-end work

Comments

@oddballdave
Copy link
Collaborator

oddballdave commented Jan 14, 2025

What happened?

Found while running unit tests in the VA Mobile App. Several unit tests fail with the Alert component when calling screen.getByRole('heading') because both the Alert and child Text components have role="heading" properties.

Specs:

  • Device:
  • OS:
  • User Account:
  • Accessibility State:

Steps to Reproduce

Run the unit tests in the VA Mobile App by executing yarn test.

Desired behavior

The VA Mobile App unit tests should not fail. The Alert component should not specify the role="heading" property. Instead, this should be handled by the child Text component by using the variant="heading" property.

Acceptance Criteria

Bug Severity - BE SURE TO ADD THE SEVERITY LABEL

See Bug Tracking for details on severity levels

  • Impact: Low
  • Frequency: Low
  • 3 - Low

Linked to Story

Screen shot(s) and additional information

Full JSON response for services related to issue (expand/collapse)

Ticket Checklist

  • Steps to reproduce are defined
  • Desired behavior is added
  • Labels added (front-end, back-end, relevant feature, accessibility, etc)
  • Estimate of 1 added (for front-end tickets)
@oddballdave oddballdave added accessibility Accessibility awareness or needs for the ticket design-system DS-Bug Bug tickets specifically for the Design System front-end Ticket requires front-end work labels Jan 14, 2025
@oddballdave oddballdave self-assigned this Jan 14, 2025
@oddballdave oddballdave linked a pull request Jan 14, 2025 that will close this issue
14 tasks
@jennb33
Copy link
Collaborator

jennb33 commented Jan 23, 2025

1/23/2025 - the deployment scheduled for 1/22/2025 was cancelled. Rolling this ticket to Sprint 10, for the next deployment (scheduled for 2/5/2025, go-live on 2/11/2025 in the App Stores)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Accessibility awareness or needs for the ticket design-system DS-Bug Bug tickets specifically for the Design System front-end Ticket requires front-end work
Projects
None yet
2 participants