Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix duplicate heading roles in Alert component #621

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

oddballdave
Copy link
Collaborator

@oddballdave oddballdave commented Jan 14, 2025

Description of Change

Removed the role="heading" property from the Alert component as this is already specified in the child Text component by virtue of the variant="heading property.

Testing Packages

Screenshots/Video

Testing

Tested library separately. Also verified this allowed the VA Mobile App unit tests to function properly.

  • Tested on iOS
  • Tested on Android
  • Tested on Web

PR Checklist

Code reviewer validation:

  • General
    • PR is linked to ticket(s)
    • PR has changelog label applied if it's to be included in the changelog
    • Acceptance criteria:
      • All satisfied or
      • Documented reason for not being performed or
      • Split to separate ticket and ticket is linked by relevant AC(s)
    • Above PR sections adequately filled out
    • If any breaking changes, in accordance with the pre-1.0.0 versioning guidelines: a CU ticket has been created for the VA Mobile App detailing necessary adjustments with the package version that will be published by this ticket
  • Code
    • Tests are included if appropriate (or split to separate ticket)
    • New functions have proper TSDoc annotations

Publish

If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:

@oddballdave oddballdave marked this pull request as ready for review January 14, 2025 19:43
@oddballdave oddballdave requested a review from a team as a code owner January 14, 2025 19:43
@oddballdave oddballdave added changelog design-system DS-Bug Bug tickets specifically for the Design System labels Jan 14, 2025
Copy link

@DonMcCaugheyUSDS DonMcCaugheyUSDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@kimmccaskill-oddball
Copy link
Collaborator

Looks pretty straightforward thanks!

@Eallan919
Copy link

These PR's are blocked because we are not authorized to merge PR's to main in the DS Library: #617 & #621. We are also likely blocked on publishing/releasing the DS Library package, which happens after we merge.

1 similar comment
@Eallan919
Copy link

These PR's are blocked because we are not authorized to merge PR's to main in the DS Library: #617 & #621. We are also likely blocked on publishing/releasing the DS Library package, which happens after we merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog design-system DS-Bug Bug tickets specifically for the Design System
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG - Sev-3 - All - Alert component has duplicate heading accessibility roles when not expandable
5 participants