Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

10: [ART] POA request resolution validates unique POA request #20053

Merged
merged 2 commits into from
Jan 10, 2025
Merged

10: [ART] POA request resolution validates unique POA request #20053

merged 2 commits into from
Jan 10, 2025
+24 −0

Conversation

nihil2501
Copy link
Contributor

@nihil2501 nihil2501 commented Dec 31, 2024 •
edited by ojbucao
Loading

Add Unique Validation for POA Request Resolutions

Description

This pull request introduces a uniqueness constraint for power_of_attorney_request in the PowerOfAttorneyRequestResolution model to ensure that each POA request can only be resolved once.

Key Changes

  • Model Validation:

    • Added a validates :power_of_attorney_request, uniqueness: true constraint to enforce uniqueness for POA requests.

  • Test Coverage:

    • Created a new RSpec test suite for PowerOfAttorneyRequestResolution to verify the uniqueness validation.
    • The test ensures an appropriate error message is displayed when a duplicate POA resolution is attempted.

@nihil2501 nihil2501 changed the title Art/poa requests/part 5/representatives.5 10: [ART] POA request resolution validates unique POA request Dec 31, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to art/poa-requests/part-5/representatives.5/main/main December 31, 2024 03:12 Inactive
@ojbucao ojbucao force-pushed the art/poa-requests/part-5/representatives.4 branch from fa23fd0 to 22adafc Compare January 9, 2025 22:48
@ojbucao ojbucao force-pushed the art/poa-requests/part-5/representatives.5 branch from bb50832 to b949420 Compare January 9, 2025 23:14
@ojbucao ojbucao self-requested a review January 9, 2025 23:17
@va-vfs-bot va-vfs-bot temporarily deployed to art/poa-requests/part-5/representatives.5/main/main January 9, 2025 23:36 Inactive
@ojbucao ojbucao force-pushed the art/poa-requests/part-5/representatives.4 branch from 22adafc to f3ebe6d Compare January 10, 2025 02:34
@ojbucao ojbucao force-pushed the art/poa-requests/part-5/representatives.5 branch from b949420 to 707e7fa Compare January 10, 2025 02:39
@va-vfs-bot va-vfs-bot temporarily deployed to art/poa-requests/part-5/representatives.5/main/main January 10, 2025 02:41 Inactive
@ojbucao ojbucao force-pushed the art/poa-requests/part-5/representatives.4 branch from 52095eb to abb7e62 Compare January 10, 2025 16:46
@ojbucao ojbucao force-pushed the art/poa-requests/part-5/representatives.5 branch from 707e7fa to b0a2056 Compare January 10, 2025 17:15
@va-vfs-bot va-vfs-bot temporarily deployed to art/poa-requests/part-5/representatives.5/main/main January 10, 2025 17:23 Inactive
@ojbucao ojbucao marked this pull request as ready for review January 10, 2025 17:46
@ojbucao ojbucao requested review from a team as code owners January 10, 2025 17:46
@ojbucao ojbucao force-pushed the art/poa-requests/part-5/representatives.4 branch from abb7e62 to 8489c6d Compare January 10, 2025 18:19
@ojbucao ojbucao requested a review from a team as a code owner January 10, 2025 18:19
@ojbucao ojbucao force-pushed the art/poa-requests/part-5/representatives.5 branch from b0a2056 to efb52da Compare January 10, 2025 18:23
@va-vfs-bot va-vfs-bot temporarily deployed to art/poa-requests/part-5/representatives.5/main/main January 10, 2025 18:53 Inactive
@ojbucao ojbucao force-pushed the art/poa-requests/part-5/representatives.4 branch 2 times, most recently from e963714 to 8dd47f9 Compare January 10, 2025 19:22
@platform-support-slack-integration platform-support-slack-integration bot mentioned this pull request Jan 10, 2025
Open
LindseySaari
LindseySaari previously approved these changes Jan 10, 2025
View reviewed changes
@LindseySaari LindseySaari mentioned this pull request Jan 10, 2025
Open
Base automatically changed from art/poa-requests/part-5/representatives.4 to master January 10, 2025 20:30
@ojbucao ojbucao dismissed LindseySaari’s stale review January 10, 2025 20:30

The base branch was changed.

@ojbucao ojbucao force-pushed the art/poa-requests/part-5/representatives.5 branch 2 times, most recently from ad56981 to ba15e89 Compare January 10, 2025 20:34
@ojbucao ojbucao force-pushed the art/poa-requests/part-5/representatives.5 branch from ba15e89 to 3f85344 Compare January 10, 2025 20:38
@ojbucao ojbucao force-pushed the art/poa-requests/part-5/representatives.5 branch from 3f85344 to dcd2fc5 Compare January 10, 2025 20:47
@ojbucao ojbucao requested a review from a team January 10, 2025 21:00
@ojbucao ojbucao merged commit fe87320 into master Jan 10, 2025
26 checks passed
@ojbucao ojbucao deleted the art/poa-requests/part-5/representatives.5 branch January 10, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojbucao ojbucao ojbucao approved these changes

@LindseySaari LindseySaari LindseySaari approved these changes

Assignees
No one assigned
Labels
art-mvp-prstack benefits-accredited-rep-facing require-backend-approval test-failure test-passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nihil2501 @LindseySaari @ojbucao @va-vfs-bot