Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sorbet] Add strict typing for logger formats #11480

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

markhallen
Copy link
Contributor

@markhallen markhallen commented Feb 4, 2025

What are you trying to accomplish?

This PR adds strict typing to the logger formats Dependabot::Logger::BasicFormatter and Dependabot::Logger::JobFormatter.

How will you know you've accomplished your goal?

  • The code has been refactored to be type-safe with Sorbet, eliminating reliance on unsafe casts.
  • The functionality should remain unchanged.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@markhallen markhallen force-pushed the markhallen/strict-type-logger-formats branch from 3a72c73 to d3026c6 Compare February 4, 2025 15:14
@markhallen markhallen marked this pull request as ready for review February 4, 2025 15:51
@markhallen markhallen requested a review from a team as a code owner February 4, 2025 15:51
abdulapopoola
abdulapopoola previously approved these changes Feb 4, 2025
@JamieMagee JamieMagee added the sorbet 🍦 Relates to Sorbet types label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sorbet 🍦 Relates to Sorbet types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants