FORK: Fix WEBHOOK_DISABLE_NAMESPACE_OWNERSHIP env-var (knative#3107)

Signed-off-by: Mathew Wicks <[email protected]>

webhook/configmaps/controller.go

@@ -47,6 +47,12 @@ func NewAdmissionController(
 	secretInformer := secretinformer.Get(ctx)
 	options := webhook.GetOptions(ctx)
 
+	// if this environment variable is set, it overrides the value in the Options
+	disableNamespaceOwnership := webhook.DisableNamespaceOwnershipFromEnv()
+	if disableNamespaceOwnership != nil {
+		options.DisableNamespaceOwnership = *disableNamespaceOwnership
+	}
+
 	key := types.NamespacedName{Name: name}
 
 	wh := &reconciler{

webhook/resourcesemantics/defaulting/controller.go

@@ -85,6 +85,12 @@ func newController(ctx context.Context, name string, optsFunc ...OptionFunc) *co
 		f(opts)
 	}
 
+	// if this environment variable is set, it overrides the value in the Options
+	disableNamespaceOwnership := webhook.DisableNamespaceOwnershipFromEnv()
+	if disableNamespaceOwnership != nil {
+		wopts.DisableNamespaceOwnership = *disableNamespaceOwnership
+	}
+
 	key := types.NamespacedName{Name: name}
 
 	wh := &reconciler{

webhook/resourcesemantics/validation/controller.go

@@ -71,6 +71,12 @@ func newController(ctx context.Context, name string, optsFunc ...OptionFunc) *co
 		f(opts)
 	}
 
+	// if this environment variable is set, it overrides the value in the Options
+	disableNamespaceOwnership := webhook.DisableNamespaceOwnershipFromEnv()
+	if disableNamespaceOwnership != nil {
+		woptions.DisableNamespaceOwnership = *disableNamespaceOwnership
+	}
+
 	wh := &reconciler{
 		LeaderAwareFuncs: pkgreconciler.LeaderAwareFuncs{
 			// Have this reconciler enqueue our singleton whenever it becomes leader.

webhook/webhook.go

@@ -164,12 +164,6 @@ func New(
 		return nil, fmt.Errorf("unsupported TLS version: %d", opts.TLSMinVersion)
 	}
 
-	// if the environment variable is set, it overrides the value in the Options
-	disableNamespaceOwnership := DisableNamespaceOwnershipFromEnv()
-	if disableNamespaceOwnership != nil {
-		opts.DisableNamespaceOwnership = *disableNamespaceOwnership
-	}
-
 	syncCtx, cancel := context.WithCancel(context.Background())
 
 	webhook = &Webhook{