-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][#25] 카드 메모 api, 카드 api 수정 #33
Conversation
07a6457
to
35dee63
Compare
return ResponseEntity.ok().body(null); | ||
} | ||
|
||
@DeleteMapping("/{card-id}/card-momo/{card-memo-id}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
card-momo 오타났습니다.
String updatedDate | ||
) { | ||
|
||
public static CardMemoGetResponse of(CardMemo cardMemo) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
파라미터 하나면 이름이 from이 좋을 것 같습니다
String type | ||
) { | ||
|
||
public static TagGetResponse of(Tag tag) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from이 좋을 것 같습니다
@@ -29,6 +29,15 @@ public class CardMemo extends BaseEntity { | |||
@JoinColumn(name = "card_id") | |||
private Card card; | |||
|
|||
public CardMemo(Card card, String content) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
생성자가 왜 두개인가용?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오타이슈ㅠㅠ
|
||
Card card = cardRepository.findByIdAndUser(cardId, user) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cardId만 있어도 찾을 수 있지 않나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
카드 소유자 확인건으로 기검토 완료건입니답~
return new CardMemoCreateResponse(cardMemo.getId(), cardMemo.getContent()); | ||
} | ||
|
||
public void updateCardMemo(User user, CardMemoContentUpdateRequest request, Long cardId, Long cardMemoId) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Transcational 붙여야할 것 같습니다
cardMemoRepository.save(cardMemo); | ||
} | ||
|
||
public void deleteCardMemo(User user, Long cardId, Long cardMemoId) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Transcational 붙여야할 것 같습니다
} | ||
|
||
@Transactional | ||
public void addCardTag(User user, Long cardId, Long tagId) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addTagToCard가 좋을 것 같음
.toList(); | ||
} | ||
|
||
public List<TagGetResponse> getCardTagList(User user, Long cardId) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getTagListInCard 가 좋을 것 같습니다
} | ||
|
||
@Transactional | ||
public void deleteCardTag(User user, Long cardId, Long tagId) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleteTagToCard가 좋을것 같습니다
🌱 관련 이슈
📌 작업 내용 및 특이사항
📝 참고사항
📚 기타