Merge branch 'master' into suisin/UPM631/add_bangladesh_language

.github/CODEOWNERS

@@ -0,0 +1,6 @@
+#  Configuration of code ownership and review approvals for the binary-com/deriv-app repo.
+#
+#  More info: https://help.github.com/articles/about-codeowners/
+#
+
+* @binary-com/write-admin-smartcharts

.github/actions/checkout/action.yml

@@ -0,0 +1,68 @@
+name: Checkout
+
+inputs:
+    fetch-depth:
+        default: 1
+        required: false
+        type: number
+    path:
+        required: false
+        type: string
+    repository:
+        default: ${{ github.repository }}
+        required: false
+        type: string
+    ref:
+        required: false
+        type: string
+    alternate_repository:
+        required: false
+        type: string
+    alternate_ref:
+        required: false
+        type: string
+    token:
+        default: ${{ github.token }}
+        required: false
+        type: string
+
+outputs:
+    ref_exists:
+        description: 'Specifies whether the ref exists or not'
+        value: ${{ steps.repo.outputs.ref-exists }}
+
+runs:
+    using: composite
+
+    steps:
+        - id: repo
+          shell: bash
+          env:
+              GH_TOKEN: ${{ inputs.token }}
+          run: |
+              if git ls-remote --heads --quiet --exit-code https://${{ inputs.token }}@github.com/${{ inputs.repository }}.git ${{ inputs.ref }}
+              then
+                echo "::notice::Checkout: ${{ inputs.repository }} using ${{ inputs.ref }}"
+                echo "ref-exists=true" >> $GITHUB_OUTPUT
+              else
+                echo "::notice::Checkout: ${{ inputs.repository }} does not have ref ${{ inputs.ref }} (fallback to ${{ inputs.alternate_ref }})"
+                echo "ref-exists=false" >> $GITHUB_OUTPUT
+              fi
+
+        - if: steps.repo.outputs.ref-exists == 'true'
+          uses: actions/checkout@a12a3943b4bdde767164f792f33f40b04645d846
+          with:
+              fetch-depth: ${{ inputs.fetch-depth }}
+              path: ${{ inputs.path }}
+              repository: ${{ inputs.repository }}
+              ref: ${{ inputs.ref }}
+              token: ${{ inputs.token }}
+
+        - if: steps.repo.outputs.ref-exists == 'false'
+          uses: actions/checkout@a12a3943b4bdde767164f792f33f40b04645d846
+          with:
+              fetch-depth: ${{ inputs.fetch-depth }}
+              path: ${{ inputs.path }}
+              repository: ${{ inputs.alternate_repository }}
+              ref: ${{ inputs.alternate_ref }}
+              token: ${{ inputs.token }}

.github/dependabot.yml

@@ -0,0 +1,10 @@
+version: 2
+updates:
+  - package-ecosystem: npm
+    directory: "/"
+    schedule:
+      interval: daily
+ - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "daily"

.github/workflows/generate_and_push_deriv_charts.yml

@@ -9,7 +9,7 @@ jobs:
         steps:
             - name: Setup node and npm
               id: step1
-              uses: actions/setup-node@v2
+              uses: actions/setup-node@9ced9a43a244f3ac94f13bfd896db8c8f30da67a
               with:
                   node-version: '18'
                   check-latest: true
@@ -18,7 +18,7 @@ jobs:
                   NODE_AUTH_TOKEN: ${{ secrets.NPM_ACCESS_TOKEN }}
             - name: Checkout repo
               id: step2
-              uses: actions/checkout@v3
+              uses: actions/checkout@a12a3943b4bdde767164f792f33f40b04645d846
               with:
                   fetch-depth: 1
                   ref: master

.github/workflows/generate_preview_link.yml

@@ -0,0 +1,128 @@
+name: Generate preview link
+
+on:
+  pull_request_target:
+    types: [opened, synchronize]
+
+concurrency:
+    group: cloudflare-pages-build-${{ github.head_ref }}
+    cancel-in-progress: true
+
+jobs:
+    build_and_deploy_preview_link:
+        runs-on: Ubuntu-latest
+        permissions:
+          checks: write
+          pull-requests: write
+        steps:
+          - name: Verify user
+            uses: "deriv-com/shared-actions/.github/actions/verify_user_in_organization@v1"
+            with:
+              username: ${{github.event.pull_request.user.login}}
+              token: ${{ secrets.PERSONAL_ACCESS_TOKEN }}    
+
+          - name: Post preview build comment
+            id: post_preview_build_comment
+            uses: 'deriv-com/shared-actions/.github/actions/post_preview_build_comment@v1'
+            with:
+                  issue_number: ${{github.event.number}}
+                  head_sha: ${{github.event.pull_request.head.sha}}
+
+          - name: Checkout SmartCharts     
+            uses: 'binary-com/SmartCharts/.github/actions/checkout@master'
+            with:
+                  repository: ${{github.event.pull_request.user.login}}/SmartCharts
+                  path: SmartCharts
+                  ref: ${{github.head_ref}}
+                  alternate_repository: 'binary-com/SmartCharts'
+                  alternate_ref: master
+
+          - name: Checkout deriv-app
+            id:   deriv_app
+            uses: 'binary-com/SmartCharts/.github/actions/checkout@master'
+            with:
+                  repository: ${{github.event.pull_request.user.login}}/deriv-app
+                  path: deriv-app
+                  ref: ${{github.head_ref}}
+                  alternate_repository: 'binary-com/deriv-app'
+                  alternate_ref: master
+
+          - name: Custom flutter-chart
+            id:   flutter_chart
+            uses: 'binary-com/SmartCharts/.github/actions/checkout@master'
+            with:
+                  repository: ${{github.event.pull_request.user.login}}/flutter-chart
+                  path: flutter-chart
+                  ref: ${{github.head_ref}}
+                  alternate_repository: 'regentmarkets/flutter-chart'
+                  alternate_ref: fe-changes
+                  token: ${{ secrets.REPO_READ_TOKEN }}
+
+          - uses: subosito/flutter-action@v2
+            with:
+                  flutter-version: '3.10.6'
+                  channel: 'stable'
+                  cache: true
+
+          - name: Add SSH key
+            run: |
+              mkdir -p ~/.ssh
+              echo "${{ secrets.SSH_KEY }}" > ~/.ssh/github_action_key
+              chmod 600 ~/.ssh/github_action_key
+
+          - name: Build flutter
+            env:
+              GIT_SSH_COMMAND: 'ssh -i ~/.ssh/github_action_key'  
+            run: |
+                  cd SmartCharts/chart_app
+                  flutter pub get
+                  flutter build web --web-renderer html --release
+
+          - name: Setup Node
+            uses: actions/setup-node@b39b52d1213e96004bfcb1c61a8a6fa8ab84f3e8
+            with:
+                  node-version: 18.x
+
+          - name: Setup deriv-app
+            run: cd deriv-app && npm install && npm run bootstrap
+
+          - name: Remove @deriv-charts in deriv-app
+            run: rm -rf deriv-app/node_modules/@deriv/deriv-charts/dist
+
+          - name: Setup SmartCharts
+            run: cd SmartCharts && npm install
+
+          - name: Build SmartCharts
+            run: cd SmartCharts && npm run build -- --output-path ../deriv-app/node_modules/@deriv/deriv-charts/dist
+
+          - name: Run Tests
+            run: cd SmartCharts && npm run test
+
+          - name: Build deriv-app
+            env:
+              NODE_ENV: 'production'
+            run: cd deriv-app && npm run build:all
+
+          - name: Setup Node
+            uses: actions/setup-node@9ced9a43a244f3ac94f13bfd896db8c8f30da67a
+            with:
+                node-version: 20
+
+          - name: Publish to CF pages branch
+            id: publish_to_pages_branch
+            uses: 'deriv-com/shared-actions/.github/actions/publish_to_pages_branch@v1'
+            with:
+                  CLOUDFLARE_API_TOKEN: ${{ secrets.CLOUDFLARE_TEST_LINKS_API_TOKEN }}
+                  CLOUDFLARE_ACCOUNT_ID: ${{ secrets.CLOUDFLARE_TEST_LINKS_ACCOUNT_ID }}
+                  project_name: 'smartcharts-preview'
+                  branch_name: pr-${{github.event.number}}${{ steps.deriv_app.outputs.ref_exists == 'true' && '-dtra' || ''}}${{ steps.flutter_chart.outputs.ref_exists == 'true' && '-flutt' || ''}}
+                  output_dir: deriv-app/packages/core/dist
+
+          - name: 'Generate preview link comment'
+            if: always() && steps.post_preview_build_comment.outcome == 'success'
+            uses: 'deriv-com/shared-actions/.github/actions/post_preview_link_comment@v1'
+            with:
+                  issue_number: ${{github.event.number}}
+                  check_run_id: ${{steps.post_preview_build_comment.outputs.check_run_id}}
+                  preview_url: ${{steps.publish_to_pages_branch.outputs.cf_pages_url}}
+                  status: ${{job.status}}

chart_app/lib/src/models/indicators.dart

@@ -309,7 +309,7 @@ class IndicatorsModel {
           values: values,
         ));
       } else if (item is AlligatorSeries) {
-        //TODO : enable offset after fixing in the flutter charts
+        //TO DO : enable offset after fixing in the flutter charts
         tooltipContent.add(JsIndicatorTooltip(
             name: AlligatorIndicatorConfig.name,
             values: <String?>[
@@ -368,6 +368,16 @@ class IndicatorsModel {
     double y,
     int bottomIndicatorIndex,
   ) {
+    /// Called to get epoch from x position
+    int? _getClosestEpoch(int? x, int granularity) {
+      try {
+        return getClosestEpoch?.call(x, granularity);
+        // ignore: avoid_catches_without_on_clauses
+      } catch (_) {
+        return null;
+      }
+    }
+
     int configIndex = 0;
     Series? bottomItemIndicator;
     final List<Series> sortedSeriesList = <Series>[...seriesList];
@@ -388,9 +398,11 @@ class IndicatorsModel {
 
     final Offset target = Offset(x, y);
     final int? epoch =
-        getClosestEpoch?.call(controller.getEpochFromX(x), granularity);
+        _getClosestEpoch(controller.getEpochFromX(x), granularity);
 
-    if (bottomItemIndicator != null && bottomIndicatorIndex != null) {
+    if (bottomItemIndicator != null &&
+        bottomIndicatorIndex > -1 &&
+        epoch != null) {
       if (bottomItemIndicator is AwesomeOscillatorSeries) {
         final List<Tick> aoEntries = bottomItemIndicator.entries ?? <Tick>[];
 
@@ -816,11 +828,11 @@ class IndicatorsModel {
             }
           }
         } else if (item is AlligatorSeries) {
-          final List<Tick> teethEntries = item.teethSeries!.entries ?? <Tick>[];
+          final List<Tick> teethEntries = item.teethSeries?.entries ?? <Tick>[];
 
-          final List<Tick> jawEntries = item.jawSeries!.entries ?? <Tick>[];
+          final List<Tick> jawEntries = item.jawSeries?.entries ?? <Tick>[];
 
-          final List<Tick> lipEntries = item.lipsSeries!.entries ?? <Tick>[];
+          final List<Tick> lipEntries = item.lipsSeries?.entries ?? <Tick>[];
 
           if (isPointOnIndicator(
                 teethEntries,
@@ -864,7 +876,7 @@ class IndicatorsModel {
     if (index != null) {
       final int quoteIndex = index - offset;
 
-      if (quoteIndex <= entries.length - 1) {
+      if (quoteIndex <= entries.length - 1 && quoteIndex > 0) {
         final Tick prevIndex = entries[quoteIndex - 1];
         final Tick currIndex = entries[quoteIndex];