Akmal / Fix: do not close forex markets #1271
Conversation
| @@ -31,7 +31,7 @@ const ItemName = React.memo(({ item: { itemId, display } }: { item: TSubCategory | |||
| const ItemDetail = React.memo( | |||
| ({ favoritesId, item: { dataObject, itemId } }: { favoritesId: string; item: TSubCategoryDataItem }) => ( | |||
| <div className='sc-mcd__item__detail'> | |||
| {dataObject && (dataObject.exchange_is_open === undefined || dataObject.exchange_is_open) ? ( | |||
| {dataObject && (dataObject.market === 'forex' || dataObject.exchange_is_open === undefined || dataObject.exchange_is_open) ? ( | |||
There was a problem hiding this comment.
| {dataObject && (dataObject.market === 'forex' || dataObject.exchange_is_open === undefined || dataObject.exchange_is_open) ? ( | |
| {dataObject && (dataObject.market === 'forex' || dataObject.exchange_is_open === undefined || dataObject.exchange_is_open) ? ( |
just a question. are we specifically checking for undefined? looks kinda sus 👀
There was a problem hiding this comment.
Yes 😁 It was added a long time ago as well 😄
There was a problem hiding this comment.
I think the point of this was that it should only show CLOSED when the market is explicitly closed, and not when the response is undefined/not received yet
| return ( | ||
| <div className='cq-symbol-select-btn'> | ||
| <div className='cq-symbol-select-btn__container'> | ||
| <SymbolInfo /> | ||
| {!isSymbolOpen && <div className='cq-symbol-closed-text'>{t.translate('CLOSED')}</div>} | ||
| {!isSymbolOpen && !is_forex_market && <div className='cq-symbol-closed-text'>{t.translate('CLOSED')}</div>} |
There was a problem hiding this comment.
I think sometimes Forex markets can be closed from BO. Will it still show Closed here if it is closed in BO?
There was a problem hiding this comment.
Hmm, no, unfortunately this is required due to forex markets being marked as closed when the daily blackout happens. But in case the markets are closed from BO, the user will not be able to make any trade and it will show the error on the right side. I think the idea of the card is that the forex markets do not close in general, so if trading is stopped for some reason, it still should not be marked as closed on our side.
There was a problem hiding this comment.
@akmal-binary Looks like Forex market will be closed on Weekends. We still need to show Closed label for it.
There was a problem hiding this comment.
Thanks Bala, I'll change the logic accordingly 👌🏻
No description provided.