Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suisin/chore: add bangladesh langauge #1486

Merged
merged 5 commits into from
Feb 12, 2024
Merged

Suisin/chore: add bangladesh langauge #1486

merged 5 commits into from
Feb 12, 2024

Conversation

suisin-deriv
Copy link
Contributor

@suisin-deriv suisin-deriv commented Feb 1, 2024 •
edited
Loading

Description

Adding Bangladesh language to smartcharts

Cards

review-deriv
review-deriv reviewed Feb 1, 2024
View reviewed changes
Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

henry-deriv
henry-deriv approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@henry-deriv henry-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please install flutter on your local machine 😃

@suisin-deriv suisin-deriv requested a review from a team as a code owner February 5, 2024 06:29
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

Preview Link: https://pr-1486.smartcharts-preview.pages.dev

Name Result
Build status Completed ✅
Preview URL Visit Preview
Action URL Visit Action

@balakrishna-deriv balakrishna-deriv merged commit 98e10b7 into deriv-com:master Feb 12, 2024
3 checks passed
ahmadtaimoor-deriv pushed a commit to ahmadtaimoor-deriv/SmartCharts that referenced this pull request Feb 20, 2024
@suisin-deriv @ahmadtaimoor-deriv
Suisin/chore: add bangladesh langauge (deriv-com#1486)
1f9def1 
* chore: add bangladesh langauge

* chore: empty commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@review-deriv review-deriv review-deriv left review comments

@ahmadtaimoor-deriv ahmadtaimoor-deriv ahmadtaimoor-deriv approved these changes

@henry-deriv henry-deriv henry-deriv approved these changes

@farabi-deriv farabi-deriv farabi-deriv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@suisin-deriv @farabi-deriv @henry-deriv @ahmadtaimoor-deriv @review-deriv @balakrishna-deriv