-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DTRA]/UPM-635/Ahmad/Arabic lang fix #1515
[DTRA]/UPM-635/Ahmad/Arabic lang fix #1515
Conversation
* chore: remove chartiq * chore: add adapter store * refactor timeperiod * chore: add more calls in the adapter * fix chartType * savetoLocalstorage * chore: remove unwanted fn * update context * chore: remove stx * chore: update feed calls * chore: remove unused core * remove few props from timestore * chore: remove unused code * chore: remove chartiq related code * chore: store changes * chore: barriers integration #1 * remove barriers and integrate it with flutter * fix: last digit * feat: markers integration * chore: fix fast markers * feat: add crosshair integration * chore: set crosshair cursor * chore: fix crosshair hover * chore: add ignore css * Revert "remove barriers and integrate it with flutter" This reverts commit b043b25. * chore: barrier integration * chore: fix digits markers placement * fix: check chart load state * fix: get interpolated tick * chore: add dataFitEnabled flag * chore: fix chart adapter granularity * chore: update isLive & dateFitEnabled * chore: add actions * fix: duplicate tick * add indicator config * add guid * feat: indicators integration * chore: transform color codes * fix: download as png and csv * refactor: use html2canvas from npm * fix: indicator configs * refactor: chart adapter store * refactor: chart interops * chore: update chart props and fix studies * refactor: remove current spot * chore: remove stx * chore: add flutter chart app * remove: chartiq scripts * chore: add chart_app to git * chore: integrate more chart types * chore: fix chart type and theme on int * chore: add indicator bars * add ma and fieldtype short code * feat: add indicator options * chore: update crosshair visibility * chore: cleanup crosshair and fix issues * chore: fix warnings * refactor * chore: remove chartiq injections * chore: trackpad zoom * chore: fix time store * chore: add documentation * refactor: currentClsoe * refactor: stores * refactor: remove ciq refs * chore: update webpack and assets * chore: format sass files * chore: remove inline source map * fix: more bugs * chore: add copy pattern * fix: contract replay request and remove comparison data * chore: follow mode check * fix: empty granularity set * fix: review comments * fix: bottom widgets height * update name id to flutter_chart_id * refactor: change name to flutter_chart_id * chore: remove console * add shortname * refactor: move web related painters * refactor: move marker icon painters * refactor: move marker painting to smartcharts * refactor: add web marker * delete studies by index * chore: add custom color for marker * chore: update marker paintings * feat: accumulators painter * chore: update color from string * restore layout after the chart is loaded * fix: restore chart * chore: add marker type * add hasPersistentBorders config * move isChartLoaded * add maxCurrentTickOffset * fix: late initialization error * fix dart issues * fix: unsubscribe issue * gator series * add macd config * chore: add indicator options * refactor: getDrawTools to func * refactor: indicator configs * fix: chartType change to undefined * fix: granularity issue * new layout id * chore: remove CIQ * chore: remove unused script * refactor: adjust timer * move epoch conversion * chore: add title * feat: add expand/collapse and move icons * fix: indicator removal and title * refactor: cleanup * refactor: add_ons_repository * fix: crosshair on restore * chore: fix drawing tools icon in the main screen * feat: add scale and scroll * chore: prevent zooming on barriers * chore: customize msPerPx and leftMargin * chore: fix clear all indicators * chore: add clear all indicators function * chore: add rainbow colors * refactor: indicators and add tooltip * fix: tooltip bugs * refoctor: fix typo and add gator tooltip * chore: add macd tooltips and refactor * chore: add smi tooltip values * chore: add indicators * fix: index out of bound exception * chore: switch theme for indicators * fix: tslint issue * fix: channel fix and donchian * chore: add pipsize * fix: indicator bugs * chore: change to upper case * fix: feed issue for 2 second intervals * fix: crosshair decimal places * fix: new tick barrier * chore: fix dark theme container * fix: high/low barrier width * fix: feed issue * chore: fix draggable barrier * chore: fix barrier issues and symbol close * refactor: helpers * fix: price line width * fix: price line width * fix: chart live status update on contract close * chore: fix chart close issue * chore: remove lodash dependency * chore: add showLastIndicator config * chore: add decimal places for indicator tooltip content * fix: adx indicator config * refactor: initial chart data loaded * chore: set initial chart data * chore: add mount prop * chore: add yAxisWidth to api * refactor: chart_app * refactor: chart app * chore: pass isMobile to drawings * fix: indicator index and accumulator drawing * chore: fix streams * fix: feed issue * refactor: controller functions * refactor: scale * fix: prevent datafit contract from being scrolled * chore: add chart margin * fix: tick contract issue * fix: vertical padding fraction * fix: granularity issues * fix: offset issue * chore: reset msPerPx on granularity change * fix: chart type change reaction * fix: chart type issue * fix: contract close reload issue * chore: paint on each line series paint * fix: late init * fix: template restore * chore: ignore chart_app bundle * fix: min interval width * chore: fix tick animation in data fit mode * chore: fix data fit mode in 2s ticks * fix: accumulator height offset * fix: alternative source * refactor: controller getter * fix: field options * chore: check granularity for chart style * refactor: accumulator contract painting * chore: add fast marker limit * chore: add fast marker limit #2 * chore: add wrapper controller * chore: add PainterProps * chore: add opacity and zoom * fix: font size * fix: types * fix: lint errors * fix: eslint errors * chore: refactor chart controller * fix: catch all errors * chore: add binary search * fix: crosshair position * chore: add max interval width for candles style * chore: add webpack ignore * chore: simplify network reconnect * chore: add loading animation color * chore: fix mobile scaling * chore: remove touch listeners * chore: add scroll to recent component * chore: add crosshair getter functions * chore: indicator index * chore: clamp deltaY values to fix scaling on wheel * chore: add rainbow line styles --------- Co-authored-by: balakrishna-binary <[email protected]>
* chore: remove chartiq * chore: add adapter store * refactor timeperiod * chore: add more calls in the adapter * fix chartType * savetoLocalstorage * chore: remove unwanted fn * update context * chore: remove stx * chore: update feed calls * chore: remove unused core * remove few props from timestore * chore: remove unused code * chore: remove chartiq related code * chore: store changes * chore: barriers integration #1 * remove barriers and integrate it with flutter * fix: last digit * feat: markers integration * chore: fix fast markers * feat: add crosshair integration * chore: set crosshair cursor * chore: fix crosshair hover * chore: add ignore css * Revert "remove barriers and integrate it with flutter" This reverts commit b043b25. * chore: barrier integration * chore: fix digits markers placement * fix: check chart load state * fix: get interpolated tick * chore: add dataFitEnabled flag * chore: fix chart adapter granularity * chore: update isLive & dateFitEnabled * chore: add actions * fix: duplicate tick * add indicator config * add guid * feat: indicators integration * chore: transform color codes * fix: download as png and csv * refactor: use html2canvas from npm * fix: indicator configs * refactor: chart adapter store * refactor: chart interops * chore: update chart props and fix studies * refactor: remove current spot * chore: remove stx * chore: add flutter chart app * remove: chartiq scripts * chore: add chart_app to git * chore: integrate more chart types * chore: fix chart type and theme on int * chore: add indicator bars * add ma and fieldtype short code * feat: add indicator options * chore: update crosshair visibility * chore: cleanup crosshair and fix issues * chore: fix warnings * refactor * chore: remove chartiq injections * chore: trackpad zoom * chore: fix time store * chore: add documentation * refactor: currentClsoe * refactor: stores * refactor: remove ciq refs * chore: update webpack and assets * chore: format sass files * chore: remove inline source map * fix: more bugs * chore: add copy pattern * fix: contract replay request and remove comparison data * chore: follow mode check * fix: empty granularity set * fix: review comments * fix: bottom widgets height * update name id to flutter_chart_id * refactor: change name to flutter_chart_id * chore: remove console * add shortname * refactor: move web related painters * refactor: move marker icon painters * refactor: move marker painting to smartcharts * refactor: add web marker * delete studies by index * chore: add custom color for marker * chore: update marker paintings * feat: accumulators painter * chore: update color from string * restore layout after the chart is loaded * fix: restore chart * chore: add marker type * add hasPersistentBorders config * move isChartLoaded * add maxCurrentTickOffset * fix: late initialization error * fix dart issues * fix: unsubscribe issue * gator series * add macd config * chore: add indicator options * refactor: getDrawTools to func * refactor: indicator configs * fix: chartType change to undefined * fix: granularity issue * new layout id * chore: remove CIQ * chore: remove unused script * refactor: adjust timer * move epoch conversion * chore: add title * feat: add expand/collapse and move icons * fix: indicator removal and title * refactor: cleanup * refactor: add_ons_repository * fix: crosshair on restore * chore: fix drawing tools icon in the main screen * feat: add scale and scroll * chore: prevent zooming on barriers * chore: customize msPerPx and leftMargin * chore: fix clear all indicators * chore: add clear all indicators function * chore: add rainbow colors * refactor: indicators and add tooltip * fix: tooltip bugs * refoctor: fix typo and add gator tooltip * chore: add macd tooltips and refactor * chore: add smi tooltip values * chore: add indicators * fix: index out of bound exception * chore: switch theme for indicators * fix: tslint issue * fix: channel fix and donchian * chore: add pipsize * fix: indicator bugs * chore: change to upper case * fix: feed issue for 2 second intervals * fix: crosshair decimal places * fix: new tick barrier * chore: fix dark theme container * fix: high/low barrier width * fix: feed issue * chore: fix draggable barrier * chore: fix barrier issues and symbol close * refactor: helpers * fix: price line width * fix: price line width * fix: chart live status update on contract close * chore: fix chart close issue * chore: remove lodash dependency * chore: add showLastIndicator config * chore: add decimal places for indicator tooltip content * fix: adx indicator config * refactor: initial chart data loaded * chore: set initial chart data * chore: add mount prop * chore: add yAxisWidth to api * refactor: chart_app * refactor: chart app * chore: pass isMobile to drawings * fix: indicator index and accumulator drawing * chore: fix streams * fix: feed issue * refactor: controller functions * refactor: scale * fix: prevent datafit contract from being scrolled * chore: add chart margin * fix: tick contract issue * fix: vertical padding fraction * fix: granularity issues * fix: offset issue * chore: reset msPerPx on granularity change * fix: chart type change reaction * fix: chart type issue * fix: contract close reload issue * chore: paint on each line series paint * fix: late init * fix: template restore * chore: ignore chart_app bundle * fix: min interval width * chore: fix tick animation in data fit mode * chore: fix data fit mode in 2s ticks * fix: accumulator height offset * fix: alternative source * refactor: controller getter * fix: field options * chore: check granularity for chart style * refactor: accumulator contract painting * chore: add fast marker limit * chore: add fast marker limit #2 * chore: add wrapper controller * chore: add PainterProps * chore: add opacity and zoom * fix: font size * fix: types * fix: lint errors * fix: eslint errors * chore: refactor chart controller * fix: catch all errors * chore: add binary search * fix: crosshair position * chore: add max interval width for candles style * chore: add webpack ignore * chore: simplify network reconnect * Overlay Series hover * chore: add loading animation color * chore: fix mobile scaling * chore: remove touch listeners * chore: add scroll to recent component * chore: add crosshair getter functions * chore: indicator index * chore: clamp deltaY values to fix scaling on wheel * Indicator hover for bottom * opening config on click * hover working * small fix * all indicators except double ones * returning bottom indicator index * chore: fix multiple indicator hover issue * tooltip on indicators * fix: inconsistent indicator hover issue * debounce and ichimoku fix * fixes on the ichimoku * type change * merge conflicts sort * merge fix * review fix * Create CNAME * Delete CNAME * Throttling approach * throttle to 10 * scaling fix --------- Co-authored-by: balakrishna-binary <[email protected]> Co-authored-by: balakrishna-binary <[email protected]>
* feat: add ibm font and turbos drawings * Update src/components/Form.tsx Co-authored-by: Bahar <[email protected]> --------- Co-authored-by: Bahar <[email protected]>
* remove: chartiq scripts * chore: add chart_app to git * chore: integrate more chart types * chore: fix chart type and theme on int * chore: add indicator bars * add ma and fieldtype short code * feat: add indicator options * chore: update crosshair visibility * chore: cleanup crosshair and fix issues * chore: fix warnings * refactor * chore: remove chartiq injections * chore: trackpad zoom * chore: fix time store * chore: add documentation * refactor: currentClsoe * refactor: stores * refactor: remove ciq refs * chore: update webpack and assets * chore: format sass files * chore: remove inline source map * fix: more bugs * chore: add copy pattern * fix: contract replay request and remove comparison data * chore: follow mode check * fix: empty granularity set * fix: review comments * fix: bottom widgets height * update name id to flutter_chart_id * refactor: change name to flutter_chart_id * chore: remove console * add shortname * refactor: move web related painters * refactor: move marker icon painters * refactor: move marker painting to smartcharts * refactor: add web marker * delete studies by index * chore: add custom color for marker * chore: update marker paintings * feat: accumulators painter * chore: update color from string * restore layout after the chart is loaded * fix: restore chart * chore: add marker type * add hasPersistentBorders config * move isChartLoaded * add maxCurrentTickOffset * fix: late initialization error * fix dart issues * fix: unsubscribe issue * gator series * add macd config * chore: add indicator options * refactor: getDrawTools to func * refactor: indicator configs * fix: chartType change to undefined * fix: granularity issue * new layout id * chore: remove CIQ * chore: remove unused script * refactor: adjust timer * move epoch conversion * chore: add title * feat: add expand/collapse and move icons * fix: indicator removal and title * refactor: cleanup * refactor: add_ons_repository * fix: crosshair on restore * chore: fix drawing tools icon in the main screen * feat: add scale and scroll * chore: prevent zooming on barriers * chore: customize msPerPx and leftMargin * chore: fix clear all indicators * chore: add clear all indicators function * chore: add rainbow colors * refactor: indicators and add tooltip * fix: tooltip bugs * refoctor: fix typo and add gator tooltip * chore: add macd tooltips and refactor * chore: add smi tooltip values * chore: add indicators * fix: index out of bound exception * chore: switch theme for indicators * fix: tslint issue * fix: channel fix and donchian * chore: add pipsize * fix: indicator bugs * chore: change to upper case * fix: feed issue for 2 second intervals * fix: crosshair decimal places * fix: new tick barrier * chore: fix dark theme container * fix: high/low barrier width * fix: feed issue * chore: fix draggable barrier * chore: fix barrier issues and symbol close * refactor: helpers * fix: price line width * fix: price line width * fix: chart live status update on contract close * chore: fix chart close issue * chore: remove lodash dependency * chore: add showLastIndicator config * chore: add decimal places for indicator tooltip content * fix: adx indicator config * refactor: initial chart data loaded * chore: set initial chart data * chore: add mount prop * chore: add yAxisWidth to api * refactor: chart_app * refactor: chart app * chore: pass isMobile to drawings * fix: indicator index and accumulator drawing * chore: fix streams * fix: feed issue * refactor: controller functions * refactor: scale * fix: prevent datafit contract from being scrolled * chore: add chart margin * fix: tick contract issue * fix: vertical padding fraction * fix: granularity issues * fix: offset issue * chore: reset msPerPx on granularity change * fix: chart type change reaction * fix: chart type issue * fix: contract close reload issue * chore: paint on each line series paint * fix: late init * fix: template restore * chore: ignore chart_app bundle * fix: min interval width * chore: fix tick animation in data fit mode * chore: fix data fit mode in 2s ticks * fix: accumulator height offset * fix: alternative source * refactor: controller getter * fix: field options * chore: check granularity for chart style * refactor: accumulator contract painting * chore: add fast marker limit * chore: add fast marker limit #2 * chore: add wrapper controller * chore: add PainterProps * chore: add opacity and zoom * fix: font size * fix: types * fix: lint errors * fix: eslint errors * chore: refactor chart controller * fix: catch all errors * chore: add binary search * fix: crosshair position * chore: add max interval width for candles style * chore: add webpack ignore * chore: simplify network reconnect * Overlay Series hover * chore: add loading animation color * chore: fix mobile scaling * chore: remove touch listeners * chore: add scroll to recent component * chore: add crosshair getter functions * chore: indicator index * chore: clamp deltaY values to fix scaling on wheel * Indicator hover for bottom * opening config on click * hover working * small fix * all indicators except double ones * returning bottom indicator index * chore: fix multiple indicator hover issue * tooltip on indicators * fix: inconsistent indicator hover issue * debounce and ichimoku fix * fixes on the ichimoku * type change * drawingtool Model * add drawing * working drawing tool * Revert "working drawing tool" This reverts commit f72fc08. * Drawing tool integrated with drag issue * current changes * updated changes * restore drawing fix * refactor: simplify drawing tool creation * restore drawing working except channel,trend * fix: drawing tools hover * Restore Drawing Completed with Trend Updation issue * fix: drawing tool hover * fix: open indicator/drawing settings * restore drawing completed * small fix * change color on theme change fix * fix: drawing tool text * chore: remove tooltip on doubleclick * restore drawing by sharedPrefs * optimize onUpdate and onDeleted Function * fixing type error * Kate / DTRA-383 / Improvement/ On the Chart "price info box", date is displayed in mm/dd format (deriv-com#1446) * refactor: change time format in crosshair store * feat: add check for chart type * chore: remove extra comma * refactor: apply suggestions * refactor: revert changes with moment library * chore: add turkish language into smart charts (deriv-com#1449) Co-authored-by: Maryia <[email protected]> * Maryia/dtra-369/Send chart events using stateChangeListener for analytics collection (deriv-com#1439) * feat: add action for choosing chart type * feat: add state change events for chart type and interval * feat: add open & close events for chart mode modal * refactor: CHART_TYPE_CHANGE event * chore: add event for opening and closing markets list * feat: added symbol_change state change event * chore: add more events * chore: add more events * chore: add more events * feat: added event for adding indicator * fix: symbol change & info redirect events * refactor: getSymbolMarketCategory * feat: added final events for indicators * refactor: united info open & close into INDICATOR_INFO_TOGGLE * feat: add event for clear all button * fix: delete event for indicators * test: getSymbolMarketCategory & getTimeIntervalName * refactor: linting * fix: against empty initial chart type value * fix: indicator events * fix: send id instead of name since english version is needed for any language * fix: set symbol instea d of name to remain in english for any languages * refactor: rename variables * refactor: remove unnecessary empty object param * Maryia/DTRA-388/fix: incorrect maxTicks value for dataset length < 7 ticks (deriv-com#1448) * fix: chart scroll for 1 tick * fix: chart centering for big dataset length as well as for small one * refactor: make logic explicitly dependent on dataset * refactor: add constant * Amir/feq 217/upgrade to react 17 (deriv-com#1416) * chore: remove unused packages * build: migrate webpack version to 5 * build: upgrade node version from 12 to 18 * chore: remove unused packages * build: update svgo-loader and svg-sprite-loader * docs: update README.md * docs: update README.md * build: update node version in the yml file * chore: update node version in circleci * fix: circle ci node img * chore: upgrade react to version 17 * chore: package lock file * chore: update package version to 1.4.0 * chore: update package lock --------- Co-authored-by: Maryia <[email protected]> * refactor: load drawing tools * feat: restore drawing specific to a symbol * unselecting continuous tool on escape * indicator tooltip fix * chore: add onLoad to action * fix: continuous color change * chore: remove unused code * removing unused function * fix: crosshair hover * chore: add eslint ignore * fix: tooltip update position * adding label field in vertical/horizontal drawing * removing addOns * chore: delete drawings using id * clean up and review fixes * removing tooltip when drawing is write beneath the setting dialog * removing commented code * working drawing on release version * onload tooltip fix * Indicator Search fix * fix: prediction indicator dialog * annotation label setup with painter (no timer) * spacing fix * fixing time for tick * replacing barrier with horizontal barrier * review comments and darkmode fix --------- Co-authored-by: balakrishna-binary <[email protected]> Co-authored-by: kate-deriv <[email protected]> Co-authored-by: Sui Sin <[email protected]> Co-authored-by: Maryia <[email protected]> Co-authored-by: Amir Ali <[email protected]>
* chore: repaitn current tick on data fit enabled * chore: customize animation timings * fix: closest epoch error * chore: prevent quote and epoch from being null * chore: add webpackpreload * chore: update chart version * fix: scroll to last tick * chore: fix fast marker * fix: overlap issue in contract replay * chore: update version * feat: add accumulator barriers for closed contracts * fix * removing old changes * chore: add formatting * chore: fix style not updated issue * chore: update package * fix: indicator style not applied issue * fix: stuttered scroll * chore: update package --------- Co-authored-by: ahmadtaimoor-deriv <[email protected]>
* chore: fix routing issue * chore: add debounce to indicator hover * template incorrect indicator fix * crosshair x and y pos fix * fix: crosshair hover check * fix: crosshair issues * chore: package update * fix: crosshair move on bottom indicators * fix: navigation issue * fix: clear layout when switching to dbot chart * chore: update package * fix: zero digit issue in digit contracts * chore: safe parse json and remove gator indicator * chore: remove gator #2 * refactor: rename variable * chore: update package * fix: indicator hovers * chore: update package * chore: fix undefined symbol * fix: clean chart before init * fix: iphone se issue with yaxis padding --------- Co-authored-by: ahmadtaimoor-deriv <[email protected]>
* fixing candle color * changing color to exact hex * remove comment and add isLive * adding opacity
…ce Info (deriv-com#1461) * Akmal / feat: remove relative indicator if it's blocking current price (deriv-com#1387) * feat: remove relative indicator if it's blocking current price * chore: refactor code * feat: parse the decimal * feat: new UI for strike overlap * feat: interim solution * feature: updated UI and overlap behaviour for strike and barrier * fix stylint issues * fix: stylelint formatting * fix broken styles in vercel development bundle * feat: remove overlay from barrier * fix: overlay style * feat: trigger vercel * chore: remove unused styles * chore: apply review suggestion * fix: add missing comma * fix: inherit colors from deriv app for turbos * feat: move div to a separate component * chore: update version (deriv-com#1458) * chore: add portuguese language into SmartCharts (deriv-com#1457) * chore: update version 1.4.2 (deriv-com#1459) * setting price info crosshair on mobile * fix: moving spot price barrier with marker * fix: strike barrier moving with marker * chore: update version --------- Co-authored-by: Akmal Djumakhodjaev <[email protected]> Co-authored-by: balakrishna-deriv <[email protected]> Co-authored-by: Sui Sin <[email protected]> Co-authored-by: balakrishna-binary <[email protected]>
…#1462) * feat: implement new blue barrier in flutter charts * feat: new barrier alignment on mobile * chore: apply suggestions * fix: merge with latest * fix: failed merge cleanup
* fix: ttile issue * chore: remove tick animation and fine tune animation duration * refactor: move deriv-chart code * refactor: remove minElapsedTimeToFollow * chore: remove overrides * chore: add lower animation check * chore: add blink animation * fix: scroll to latest epoch * fix: repaint annotations * chore: optimize animation * chore: set max interval for tick contracts in contract replay * chore: add condition for tick contracts * fix: overlap fix * fix: overlap * chore: update right padding * fix: padding issues in contract replay * fix: background opacity * chore: convert range * Update chart_app/lib/src/series/blink_tick_indicator.dart * fix: markers opacity when the contract is open * chore: update animation interval for non graphic friendly os * chore: update version --------- Co-authored-by: ahmadtaimoor-deriv <[email protected]>
* fix: trackjs issue * chore: add assetbase * chore: update ts comment * chore: update npm version
* fix: scaling issue * Update chart_app/lib/src/chart_app.dart
…to fix_date_on_tooltip
…to fix_chart_arabic_lang
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR description is too short. You can use this format:
# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.
# Cards
* https://clickup.com/12345
* https://clickup.com/12346
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR description is too short. You can use this format:
# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.
# Cards
* https://clickup.com/12345
* https://clickup.com/12346
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR description is too short. You can use this format:
# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.
# Cards
* https://clickup.com/12345
* https://clickup.com/12346
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR description is too short. You can use this format:
# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.
# Cards
* https://clickup.com/12345
* https://clickup.com/12346
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR description is too short. You can use this format:
# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.
# Cards
* https://clickup.com/12345
* https://clickup.com/12346
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Preview Link: https://pr-1515-dtra.smartcharts-preview.pages.dev
|
It includes the changes required to make the flutter chart work in rtl