Added OIDC error types #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrienne-deriv
requested review from
ali-hosseini-deriv,
yashim-deriv,
amam-deriv and
thisyahlen-deriv
as code owners
cakasuma
approved these changes
Oct 28, 2024
cakasuma
reviewed
Oct 28, 2024
src/oidc/error.ts
Outdated
| } | ||
|
|
||
| export const OIDCAuthenticationError = { | ||
| FailedToFetchOIDCConfiguration: new OIDCError('Failed to fetch OIDC configuration'), |
There was a problem hiding this comment.
Was thinking to have an error code instead of message to differentiate error better
adrienne-deriv
commented
Nov 6, 2024
| AuthenticationRequestFailed = "AuthenticationRequestFailed", | ||
| AccessTokenRequestFailed = "AccessTokenRequestFailed", | ||
| LegacyTokenRequestFailed = "LegacyTokenRequestFailed", | ||
| UserManagerCreationFailed = "UserManagerCreationFailed" |
There was a problem hiding this comment.
I didn't use integers because I wanted to pass this error type into the Error interface, which does not have any integer attribute supported
thisyahlen-deriv
approved these changes
Nov 6, 2024
|
🎉 This PR is included in version 1.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation
Please include the motivation behind this change. Why is this change required? What problem does it solve?
Actions
List the actions taken to achieve this change. What steps were followed? What was modified?
Type of change
Please delete options that are not relevant.