[account-v2]/likhith/coj-707/Incorporated POO Form #14813

likhith-deriv · 2024-04-25T07:52:26Z

Changes:

Create a POO form component to accept Payment method verification details containing payment method identifier and supporting document

vercel · 2024-04-25T07:52:32Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	May 1, 2024 3:44am

coveralls · 2024-04-25T08:19:19Z

coverage: 40.339% (-0.07%) from 40.412%
when pulling b39e517 on likhith-deriv:likhith/coj-707/Create-POOForm-component
into 4d0c851 on binary-com:master.

coveralls · 2024-04-25T08:19:19Z

coverage: 40.457% (-0.02%) from 40.473%
when pulling d3225a8 on likhith-deriv:likhith/coj-707/Create-POOForm-component
into 71c6056 on binary-com:master.

github-actions · 2024-04-25T08:21:16Z

A production App ID was automatically generated for this PR. (log)

PR: [account-v2]/likhith/coj-707/Incorporated POO Form #14813
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-likhith-deriv-likhith-coj-707create-p-4f4d98.binary.sx?qa_server=red.derivws.com&app_id=24165
- Original: https://deriv-app-git-fork-likhith-deriv-likhith-coj-707create-p-4f4d98.binary.sx
App ID: 24165

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/14813](https://github.com/binary-com/deriv-app/pull/14813)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-likhith-deriv-likhith-coj-707create-p-4f4d98.binary.sx?qa_server=red.derivws.com&app_id=24165
    - **Original**: https://deriv-app-git-fork-likhith-deriv-likhith-coj-707create-p-4f4d98.binary.sx
- **App ID**: `24165`

github-actions · 2024-04-25T08:22:38Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	26
🟢 Accessibility	90
🟢 Best practices	92
🟧 SEO	81
🟧 PWA	78

Lighthouse ran with https://deriv-app-git-fork-likhith-deriv-likhith-coj-707create-p-4f4d98.binary.sx/

packages/account-v2/src/containers/POOForm/FileUploadField.tsx

packages/account-v2/src/constants/paymentMethodsConfig.ts

packages/account-v2/src/containers/POOForm/FileUploadField.tsx

packages/account-v2/src/utils/pooUtils.ts

fasihali-deriv · 2024-04-30T06:26:07Z

packages/account-v2/src/components/LinkText/LinkText.tsx

+import { Text } from '@deriv-com/ui';
+
+export const LinkText = ({ children, ...rest }: ComponentProps<typeof Text>) => (
+    <Text as='a' color='red' rel='noreferrer' target='_blank' {...rest} size='sm'>


Hi @likhith-deriv should we hardcode the color and size ?

The {...rest} should override the props if u need something specific. These are default prop values

fasihali-deriv · 2024-04-30T07:13:29Z

packages/account-v2/src/utils/pooUtils.ts

@@ -30,3 +38,26 @@ export const generatePOOInitialValues = (paymentMethodData: TPaymentMethodData)
        return acc;
    }, {} as TProofOfOwnershipFormValue);
 };
+
+const maskCardNumber = (cardNumber: string) => {
+    if (


can we move this condition out from if statement ?

Are u referring to making it ternary operator? The condition is huge, so I kept it in IF block

fasihali-deriv · 2024-04-30T07:21:15Z

packages/account-v2/src/containers/POOForm/FileUploadField.tsx

+        e.nativeEvent.stopPropagation();
+        e.nativeEvent.stopImmediatePropagation();
+
+        if (hiddenInputFieldRef.current && 'value' in hiddenInputFieldRef.current) {


can we move out this condition outside from if statement ?

I didn't understand. Can u share, what do u mean?

packages/account-v2/src/containers/PaymentMethods/PaymentMethodForm.tsx

sonarqubecloud · 2024-05-01T03:24:36Z

Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

* chore: updated Deriv-ui * feat: incorporated File upload field * fix: incorporated File upload component * feat: added POO form * feat: added POO form * feat: added POO form * fix: incorporated review comments * fix: incorporated review comment * fix: incorporated code reviews * fix: incorporated review comments

chore: updated Deriv-ui

d3225a8

likhith-deriv temporarily deployed to Preview April 25, 2024 07:52 — with GitHub Actions Inactive

likhith-deriv added 2 commits April 25, 2024 18:34

feat: incorporated File upload field

2117b68

Merge branch 'master' into likhith/coj-707/Create-POOForm-component

5cf9a85

likhith-deriv temporarily deployed to Preview April 25, 2024 14:36 — with GitHub Actions Inactive

likhith-deriv temporarily deployed to Preview April 25, 2024 14:37 — with GitHub Actions Inactive

fix: incorporated File upload component

1a69141

likhith-deriv had a problem deploying to Preview April 26, 2024 03:50 — with GitHub Actions Failure

likhith-deriv temporarily deployed to Preview April 26, 2024 03:50 — with GitHub Actions Inactive

feat: added POO form

2d2660f

likhith-deriv had a problem deploying to Preview April 26, 2024 08:35 — with GitHub Actions Failure

likhith-deriv temporarily deployed to Preview April 26, 2024 08:35 — with GitHub Actions Inactive

feat: added POO form

b22ee2f

likhith-deriv marked this pull request as ready for review April 26, 2024 08:36

likhith-deriv requested review from matin-deriv, thisyahlen-deriv, balakrishna-deriv, yashim-deriv, azmib-developer and markw-deriv as code owners April 26, 2024 08:36

likhith-deriv temporarily deployed to Preview April 26, 2024 08:36 — with GitHub Actions Inactive

hasan-deriv reviewed Apr 26, 2024

View reviewed changes

packages/account-v2/src/containers/POOForm/FileUploadField.tsx Outdated Show resolved Hide resolved

yauheni-deriv reviewed Apr 26, 2024

View reviewed changes

packages/account-v2/src/constants/paymentMethodsConfig.ts Show resolved Hide resolved

likhith-deriv requested a review from yauheni-deriv April 29, 2024 04:39

likhith-deriv added 2 commits April 29, 2024 15:36

Merge branch 'master' into likhith/coj-707/Create-POOForm-component

eed61d6

Merge branch 'master' into likhith/coj-707/Create-POOForm-component

72840df

likhith-deriv temporarily deployed to Preview April 29, 2024 11:38 — with GitHub Actions Inactive

yauheni-deriv reviewed Apr 29, 2024

View reviewed changes

packages/account-v2/src/containers/POOForm/FileUploadField.tsx Show resolved Hide resolved

amina-deriv previously approved these changes Apr 29, 2024

View reviewed changes

amina-deriv reviewed Apr 29, 2024

View reviewed changes

packages/account-v2/src/containers/POOForm/FileUploadField.tsx Show resolved Hide resolved

amina-deriv reviewed Apr 29, 2024

View reviewed changes

packages/account-v2/src/utils/pooUtils.ts Show resolved Hide resolved

likhith-deriv requested a review from yauheni-deriv April 29, 2024 17:58

fix: incorporated review comment

8f16b6d

likhith-deriv dismissed amina-deriv’s stale review via 8f16b6d April 30, 2024 06:13

likhith-deriv temporarily deployed to Preview April 30, 2024 06:13 — with GitHub Actions Inactive

likhith-deriv requested a review from amina-deriv April 30, 2024 06:14

yauheni-deriv approved these changes Apr 30, 2024

View reviewed changes

fasihali-deriv reviewed Apr 30, 2024

View reviewed changes

fix: incorporated code reviews

0619b76

likhith-deriv temporarily deployed to Preview April 30, 2024 10:29 — with GitHub Actions Inactive

amina-deriv reviewed Apr 30, 2024

View reviewed changes

packages/account-v2/src/containers/PaymentMethods/PaymentMethodForm.tsx Outdated Show resolved Hide resolved

amina-deriv reviewed Apr 30, 2024

View reviewed changes

packages/account-v2/src/containers/PaymentMethods/PaymentMethodForm.tsx Outdated Show resolved Hide resolved

fix: incorporated review comments

3167418

likhith-deriv temporarily deployed to Preview May 1, 2024 03:21 — with GitHub Actions Inactive

amina-deriv approved these changes May 1, 2024

View reviewed changes

likhith-deriv merged commit fbb91f3 into deriv-com:master May 1, 2024
7 of 8 checks passed

shahzaib-deriv mentioned this pull request May 7, 2024

[TRAH-3380] shahzaib / remove authorization and loader from options & multipliers] #15013

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[account-v2]/likhith/coj-707/Incorporated POO Form #14813

[account-v2]/likhith/coj-707/Incorporated POO Form #14813

likhith-deriv commented Apr 25, 2024 •

edited

Loading

vercel bot commented Apr 25, 2024 •

edited

Loading

coveralls commented Apr 25, 2024 •

edited

Loading

coveralls commented Apr 25, 2024

github-actions bot commented Apr 25, 2024 •

edited

Loading

github-actions bot commented Apr 25, 2024 •

edited

Loading

fasihali-deriv Apr 30, 2024

likhith-deriv Apr 30, 2024 •

edited

Loading

fasihali-deriv Apr 30, 2024

likhith-deriv Apr 30, 2024

fasihali-deriv Apr 30, 2024

likhith-deriv Apr 30, 2024 •

edited

Loading

sonarqubecloud bot commented May 1, 2024

[account-v2]/likhith/coj-707/Incorporated POO Form #14813

[account-v2]/likhith/coj-707/Incorporated POO Form #14813

Conversation

likhith-deriv commented Apr 25, 2024 • edited Loading

Changes:

vercel bot commented Apr 25, 2024 • edited Loading

coveralls commented Apr 25, 2024 • edited Loading

coveralls commented Apr 25, 2024

github-actions bot commented Apr 25, 2024 • edited Loading

github-actions bot commented Apr 25, 2024 • edited Loading

fasihali-deriv Apr 30, 2024

Choose a reason for hiding this comment

likhith-deriv Apr 30, 2024 • edited Loading

Choose a reason for hiding this comment

fasihali-deriv Apr 30, 2024

Choose a reason for hiding this comment

likhith-deriv Apr 30, 2024

Choose a reason for hiding this comment

fasihali-deriv Apr 30, 2024

Choose a reason for hiding this comment

likhith-deriv Apr 30, 2024 • edited Loading

Choose a reason for hiding this comment

sonarqubecloud bot commented May 1, 2024

Quality Gate failed

likhith-deriv commented Apr 25, 2024 •

edited

Loading

vercel bot commented Apr 25, 2024 •

edited

Loading

coveralls commented Apr 25, 2024 •

edited

Loading

github-actions bot commented Apr 25, 2024 •

edited

Loading

github-actions bot commented Apr 25, 2024 •

edited

Loading

likhith-deriv Apr 30, 2024 •

edited

Loading

likhith-deriv Apr 30, 2024 •

edited

Loading