-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DTRA-V2]/Ahmad/Barrier spot fix #17793
base: master
Are you sure you want to change the base?
[DTRA-V2]/Ahmad/Barrier spot fix #17793
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-ahmadtaimoor-deriv-fbarrierspotfix.binary.sx/ |
Pull Request Test Coverage Report for Build 12366985100Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
packages/trader/src/AppV2/Components/TradeParameters/Barrier/barrier-input.tsx
Outdated
Show resolved
Hide resolved
packages/trader/src/AppV2/Components/TradeParameters/Barrier/barrier-input.tsx
Outdated
Show resolved
Hide resolved
packages/trader/src/AppV2/Components/TradeParameters/Barrier/barrier.tsx
Outdated
Show resolved
Hide resolved
⏳ Generating Lighthouse report... |
Changes:
This PR adjust the behavior of barrier . Now if we have any of the barrier select like +1.0 , -1.0 , 1.0 . (Above spot , below spot, fixed price). if one is set , the other input fields are empty without showing any error message .
Screenshots:
Please provide some screenshots of the change.