Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitra/KYC-1852/Update the regex for first and last name validation #56

Conversation

mitra-deriv
Copy link
Contributor

As Backend updated the API to accept 1 character ( due to the Chinese language) we need to update the regex and also as whitespace is accepted and BE accepting 1 space also we should not accept space for the beginning and end of the characters.

@coveralls
Copy link
Collaborator

coveralls commented May 22, 2024

Pull Request Test Coverage Report for Build 9659435480

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 99.824%

Totals Coverage Status
Change from base Build 8921926223: 0.01%
Covered Lines: 567
Relevant Lines: 567

💛 - Coveralls

@mitra-deriv mitra-deriv changed the title Mirra/KYC-1852/Update the regex for first and last name validation Mitra/KYC-1852/Update the regex for first and last name validation Jun 19, 2024
@shayan-deriv shayan-deriv merged commit ae968b9 into deriv-com:master Jun 25, 2024
2 checks passed
Copy link

🎉 This PR is included in version 0.0.28 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants