Likhith/create custom merge function #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
likhith-deriv
requested review from
ali-hosseini-deriv,
yashim-deriv,
azmib-developer and
niloofar-deriv
as code owners
Pull Request Test Coverage Report for Build 9902250963Details
💛 - Coveralls |
yauheni-deriv
approved these changes
Jul 12, 2024
| [P in keyof T]?: TSources<T[P]>; | ||
| }; | ||
|
|
||
| const replaceValue = <T>(value: T, newValue: T): T => { |
There was a problem hiding this comment.
I was thinking is it working fine if the length of value and newValue are different? 🤔
There was a problem hiding this comment.
or here u're handling that ? 🤔
if (source[key] === null || source[key] === undefined) {
continue;
}
There was a problem hiding this comment.
ignore the comment. it's irrelevant
shayan-deriv
approved these changes
Jul 15, 2024
|
🎉 This PR is included in version 0.0.29 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a
mergefunction that can replace lodash.merge function. This can eliminate import of additional library