-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/prettier (css, html, js, json, less, md, scss, yaml) #11
feature/prettier (css, html, js, json, less, md, scss, yaml) #11
Conversation
* install node + yarn * add ignores * add package.json Signed-off-by: Matthäus Falkowski <[email protected]>
* implemented css, html, js, json, less, scss, md, yaml * basic formatting rules for added languages * remove all prettier plugins (was unacceptably slow)
* implemented: css, html, js, json, less, scss, md, yaml * basic formatting rules for added languages * remove all prettier plugins (was unacceptably slow) * specify prettier version in lock * change production docker file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your work, @wookiefriseur!
All in all, your PR looks very good and everything seems to work flawlessly.
It's perfectly fine to drop those prettier plugins for additional languages.
If Prettier is not performing well enough, we can easily support other languages like php
with other formatters.
As you can see, I have just requested some small changes which have to do with my preference for npm
over yarn
.
If you don't have any good reasons for using yarn
, I would ask you to make the switch to npm
.
In my view, installing yarn
just to install the prettier
package is a little bit pointless.
Moreover, I would be happy if we could also support the sass
syntax/language in addition to scss
.
Do you know whether Prettier also supports that?
Thank you in advance.
Have a nice evening! 😃
It can do sass using the scss parser. I avoided it because it seems to have some problems with semicolons. But it's getting fixes on a regular basis, so I'll just add it and hope for the best. |
Alright, let's hope for the best. In case there are too many bugs, we can still drop it in the future. 😃 |
After testing a bit it looks like the scss parser does not even understand Sass. Will try to find a solution at a later date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, no problem.
Feel free to merge.
Only tested manually, but works so far.
Adds support for:
css, html, javascript, json, less, markdown, scss, yaml
See #9
Notes:
yarn install
is executed (container doesn't knowpushd
andpopd
commands, which would have been an alternative)