Add proof of concept for generic mkcamp_command. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this idea a lot. The only thing I think it needs is to use pushd() instead of chdir(), as we don't want to mess with the global cwd state. Could you make that change? |
|
Sure, it will just take a while. |
|
Stefan, I'd still like to get this merged if you're using a |
|
Sure, that is fine for me. |
|
@racke So ... are you going to contribute a revised patch? I thought that's what you meant when you said "Sure, it will just take a while." before. |
|
Yes, I'm going to contribute a revised patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This by no means a complete implementation. Please tell me if you like this idea.
Our use case in
local-config:after_templates_mkcamp_command:carton install