-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Color contrast checker #131
Feature: Color contrast checker #131
Conversation
Update namespace
Update color change handling functions
Add aria-label to swap button
✅ Deploy Preview for developertools-tech ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sushma1031 great job on this!
Just a couple of adjustments needed:
- "Normal Text", "Large Text", and "Graphical Objects and User Interface Components" headings should be
h3
s, noth5
s - The foreground and background translations strings shouldn't be in all caps
- The "contrast ratio" label is not translated, also needs to be title cased
- Can the "swap" button fit in the copy/paste button group to the left of "copy"?
- The text input field under "Graphical Objects and User Interface Components" doesn't match the selected colors, is this intentional?
- The value of the contrast ratio should not be an
h3
as it is not a heading
I'll take care of the remaining changes. |
@sushma1031 I'm not sure what you mean by "I think the swap button can fit on the left, which text field should I add it to?"? I mainly just wanted the swap button to not be below the other buttons for that field, does that make sense? Apologies for not being more clear. The input text makes sense, that can stay as is. Yes, the contrast text can be larger, the current size is perfectly fine, just the semantics of heading tags does not make sense for that. Thank you! |
@sushma1031 I see what you mean, maybe it just needs a little more vertical margin to get it away from the other buttons on that field? Whichever you think is best. |
Yes, I agree that a little more vertical margin would be better, I'll add the same. |
@dlford I made the mentioned headings h3, and I think they look too large. Can we reduce the font size? |
@sushma1031 that vertical margin looks good! For the |
@dlford I made the requested changes, let me know if there's anything else! |
@sushma1031 looks great, thank you! |
Type of Pull Request
Related Issue #s or links (if any):
Fixes #96
Description of Changes
Added a text contrast checking tool in the
colors
page, similar to the website referenced in the issue. Added the required namespace and tests as well.