-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for generating sources for RHEL10. #155
Conversation
Added distconf/rhel-10-x86_64 configuration file. Add rhel10 to tests/minimal-dockerfile files Signed-off-by: Petr "Stone" Hracek <[email protected]>
@praiskup @SlouchyButton Can you please review it as soon as you have free time? Thanks. |
RPM build failures:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please bump the version in pyproject.toml
.
EPEL build failure is expected, it shouldn't be enabled (it stayed enabled for PRs for some reason).
If, for some reason, this change is required in EPEL8 and 9, then this will have to be ported to the legacy
branch, which is used for EPEL build due to outdated Python. PyPi distributed version will work everywhere as long as the python version dependency from pyproject.toml
is met.
Where did you get this error? From workflow logs I see fedora passed and epels failed with different reasons. |
Add more spaces to 'tests/minimal-dockerfile/test.exp' Signed-off-by: Petr "Stone" Hracek <[email protected]>
From Copr builds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From Copr builds.
I see that Fedora passed, so I think we good. Merging, thanks a lot for the changes. Will make a release.
Add support for generating sources for RHEL10
Added distconf/rhel-10-x86_64 configuration file.
Add rhel10 to tests/minimal-dockerfile files