Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] citro3d documentation #54

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

Conversation

oreo639
Copy link
Contributor

@oreo639 oreo639 commented Apr 7, 2021

This is a work in progress pr to finish the documentation for citro3d.
You can check out the pr's docs here:
https://oreo639.github.io/citro3d/index.html

Warning:
This may contain mistakes or poor wording choices.
Comments are welcome.

Copy link
Member

@fincs fincs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1/N review done, definitely will be more

include/c3d/attribs.h Outdated Show resolved Hide resolved
include/c3d/attribs.h Outdated Show resolved Hide resolved
include/c3d/attribs.h Outdated Show resolved Hide resolved
include/c3d/attribs.h Outdated Show resolved Hide resolved
include/c3d/attribs.h Outdated Show resolved Hide resolved
include/c3d/base.h Outdated Show resolved Hide resolved
include/c3d/base.h Outdated Show resolved Hide resolved
include/c3d/base.h Outdated Show resolved Hide resolved
include/c3d/base.h Outdated Show resolved Hide resolved
include/c3d/base.h Outdated Show resolved Hide resolved
Copy link

@thejsa thejsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proofreading for spelling and grammar; s/ctrulib/libctru; and a handful of suggestions to help things read more naturally.

include/c3d/uniforms.h Outdated Show resolved Hide resolved
include/c3d/uniforms.h Outdated Show resolved Hide resolved
include/c3d/uniforms.h Outdated Show resolved Hide resolved
include/c3d/uniforms.h Outdated Show resolved Hide resolved
include/c3d/uniforms.h Outdated Show resolved Hide resolved
include/c3d/texture.h Outdated Show resolved Hide resolved
include/c3d/types.h Outdated Show resolved Hide resolved
include/c3d/types.h Outdated Show resolved Hide resolved
include/c3d/uniforms.h Outdated Show resolved Hide resolved
include/c3d/uniforms.h Outdated Show resolved Hide resolved
@oreo639
Copy link
Contributor Author

oreo639 commented Apr 8, 2021

Thank you for the review. Sorry about the typos.

Just copying these down so they don't get buried.
What still needs to be looked into:

@oreo639 oreo639 force-pushed the c3d-docs branch 8 times, most recently from b50ed0e to 8c291c5 Compare April 11, 2021 07:28
@oreo639 oreo639 force-pushed the c3d-docs branch 5 times, most recently from c208264 to 1bf702c Compare January 25, 2022 09:59
@ian-h-chamberlain
Copy link

This PR looks great! It may have gotten a little stale but would still be valuable to have. Any chance of it being revived and/or accepted + published? I have been using https://oreo639.github.io/citro3d/index.html as my go-to for citro3d docs and would love to see this upstreamed and officially published.

If it would be helpful, I can try to review or help any other way, but I am of the opinion that any amount of docs is better than none! Let me know if there's any way to help see this PR through across the finish line.

@oreo639
Copy link
Contributor Author

oreo639 commented Jul 24, 2022

Thanks for the comments.

Here is a brief overview of what needs to be finished:

  • shadows and lighting
  • proctex
  • fog

These are things I would preferably experiment with and write applications using them and I just haven't gotten around to that yet.

Here is a list of other remaining tasks in order from most to least important:

  • Proofreading (grammar mistakes are certainly an issue, but I am primarily concerned about misleading/incorrect descriptions and missing notes/pitfalls that may not be obvious to new users of the library, one that I have since been informed of but need to commit is C3D_SetScissor(), as an example, which requires you to take into account the rotation of the screen)
  • Better descriptions (There is no point in having doFoo() -> Does foo. type descriptions)
  • Grouping everything. (similar to citro2d)
  • Possibly provide a basic description on how to use the library (similar to libtheora's documentation)

I'm sorry about the delay, my attention has primarily been focused on other projects, but I'll try to look into this more in two weeks give or take.
Any comments or feedback would be greatly appreciated.

@oreo639 oreo639 force-pushed the c3d-docs branch 3 times, most recently from 90ad127 to 49de608 Compare August 6, 2022 18:36
Copy link

@ian-h-chamberlain ian-h-chamberlain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oreo639 thanks for updating! I have not been using the library for long so I'm not sure how much review help I could provide, but I left some comments/questions for things I saw in the PR.

Depending how the maintainers feel, I think it could be valuable to merge the PR even as-is and allow for future documentation improvements to come in separately, but maybe they'd rather have everything all at once?

.github/workflows/doxygen.yaml Show resolved Hide resolved
include/c3d/base.h Outdated Show resolved Hide resolved
include/c3d/base.h Show resolved Hide resolved
include/c3d/effect.h Outdated Show resolved Hide resolved
void C3D_BlendingColor(u32 color);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing doc for C3D_EarlyDepthTest ?

void C3D_FragOpMode(GPU_FRAGOPMODE mode);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of other missing docs here as well, it looks like, but these functions also seem to be pretty self-explanatory so it may not be worth adding.

include/c3d/texture.h Outdated Show resolved Hide resolved
include/c3d/texture.h Outdated Show resolved Hide resolved
include/c3d/renderqueue.h Outdated Show resolved Hide resolved
@oreo639 oreo639 force-pushed the c3d-docs branch 5 times, most recently from 03719df to e017b56 Compare August 7, 2022 04:33
@oreo639 oreo639 force-pushed the c3d-docs branch 3 times, most recently from f221a6b to 6de6bec Compare August 7, 2022 06:23
@oreo639 oreo639 force-pushed the c3d-docs branch 2 times, most recently from 4531901 to ba70b26 Compare July 29, 2023 10:43
Copy link

@ian-h-chamberlain ian-h-chamberlain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really enough of a domain expert to review all the descriptions, but I'd love to see this accepted in some form! Thanks for your efforts @oreo639 — this looks like a huge undertaking and having citro3d documentation like this would be super valuable!

@Golem642
Copy link

Golem642 commented Jun 27, 2024

Does anyone know anything about fog/gas rendering? The wiki's empty of description with just the source code shown

@fincs
Copy link
Member

fincs commented Jun 27, 2024

There is already a fog example. As for gas support, the current code in citro3d is unfinished. I intend to revisit this soon.

@oreo639 oreo639 force-pushed the c3d-docs branch 2 times, most recently from 8d363fe to 071946f Compare December 15, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants