Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(*): wrong ephemeral events impl, indexing id in database, config typo, duplicated event error. #103

Merged
merged 3 commits into from
Jan 7, 2025
Merged

fix(*): wrong ephemeral events impl, indexing id in database, config typo, duplicated event error. #103

merged 3 commits into from
Jan 7, 2025

Conversation

kehiy
Copy link
Member

@kehiy kehiy commented Jan 6, 2025 •
edited
Loading

Description

  • immortal now sends an okay true message about successful ephemeral events.
  • id field is indexed now.
  • on duplicated messages we send ok false with proper error.
  • not returning removed events with default value on req messages.
  • fixing redis config file name.

@kehiy kehiy requested a review from ZigBalthazar January 6, 2025 21:19
ZigBalthazar
ZigBalthazar previously approved these changes Jan 7, 2025
View reviewed changes
@kehiy kehiy changed the title Clean fix(*): wrong ephemeral events impl, indexing id in database, config typo, duplicated event error. Jan 7, 2025
@kehiy kehiy requested a review from ZigBalthazar January 7, 2025 12:41
@kehiy kehiy merged commit aa44060 into dezh-tech:main Jan 7, 2025
3 checks passed
@kehiy kehiy deleted the clean branch January 7, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZigBalthazar ZigBalthazar Awaiting requested review from ZigBalthazar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kehiy @ZigBalthazar