-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Introduce TypeKey instead of String keys for named types #590
Open
frankdavid
wants to merge
8
commits into
master
Choose a base branch
from
frankdavid/typekey
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Click to see raw report
|
lwshang
approved these changes
Jan 6, 2025
adamspofford-dfinity
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We can achieve serious performance improvements by introducing a new
TypeKey
struct instead ofString
for candid types represented byType::Var
. When deserializing a candid message, we need to store information about these types (e.g. in theTypeEnv
struct). Previously, we usedBTreeMap
withString
keys. This is slow and a significant amount of time is spent looking up types by name.Optimization 1: distinguish indexed (integer) keys from String keys
When decoding type information from the message header in
binary_parser.rs
, the types are indexed. Previously these indexed types were assigned aString
key by callingformat!("table{index}")
. Working with integer keys is much faster.Optimization 2: use
HashMap
instead ofBTreeMap
Looking up values in a HashMap is much faster (especially if the keys are small).
Optimization 3: precompute hash of
String
-basedTypeKey
sBreaking changes
This is a breaking change:
Type::Var(var)
var
now has typeTypeKey
instead ofString
. Callingvar.as_str()
returns&str
andvar.to_string()
returns aString
. The string representation of indexed variables remainstable{index}
to maintain compatibility with previous versions.TypeEnv
now contains aHashMap
instead ofBTreeMap
. Code that relied on the iteration order of the map (e.g.env.0.iter()
) should make use of the newly addedTypeEnv::to_sorted_iter()
method which returns types sorted by their keys.