Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deprecate other APIs in api/call.rs #543

Merged
merged 7 commits into from
Jan 3, 2025
Merged

chore: deprecate other APIs in api/call.rs #543

merged 7 commits into from
Jan 3, 2025

Conversation

lwshang
Copy link
Contributor

@lwshang lwshang commented Jan 3, 2025

Description

The only remaining APIs in the file are ManualReply and is_recovering_from_trap.

How Has This Been Tested?

All existing tests

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@lwshang lwshang marked this pull request as ready for review January 3, 2025 01:09
@lwshang lwshang requested a review from a team as a code owner January 3, 2025 01:09
@lwshang lwshang merged commit 14e10db into next Jan 3, 2025
11 checks passed
@lwshang lwshang deleted the lwshang/deprecate_remains branch January 3, 2025 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericswanson-dfinity ericswanson-dfinity ericswanson-dfinity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lwshang @ericswanson-dfinity