feat: fromNullishNullable #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Dal Busco <[email protected]>
size-limit report 📦
|
AntonioVentilii
previously approved these changes
Jan 20, 2025
AntonioVentilii
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In Juno, I often encounter a pattern where an optional Candid variant of an optional Candid variant needs to be transformed into a nullish value. To simplify this, I introduced a utility (PR) to shorten the pattern since each
fromNullableof anundefinedvalue requires the chaining operation?? [].I took a quick look at the NNS dapp and OISY, and it seems to follow a similar pattern. Therefore, I considered adding the utility to
@dfinity/utils.Notes
Not against better naming?
Changes
fromNullishNullabledescribe(in addition to the test for the new function)