feat: init new zod-schemas library #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Dal Busco <[email protected]>
size-limit report 📦
|
Signed-off-by: David Dal Busco <[email protected]>
…/init-zod-schemas
Signed-off-by: David Dal Busco <[email protected]>
Signed-off-by: David Dal Busco <[email protected]>
AntonioVentilii
previously approved these changes
Jan 20, 2025
Signed-off-by: David Dal Busco <[email protected]>
…/init-zod-schemas
AntonioVentilii
approved these changes
Jan 20, 2025
This was referenced Jan 20, 2025
peterpeterparker
added a commit
that referenced
this pull request
Jan 20, 2025
# Motivation The size limit setup was missing in #812 for the new zod-schemas lib. Signed-off-by: David Dal Busco <[email protected]>
peterpeterparker
added a commit
that referenced
this pull request
Jan 20, 2025
# Motivation Accepting all zod v3 library in #812 was not replicated, it seems, in package-lock.json. Signed-off-by: David Dal Busco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have some Zod schemas that are repeated in OISY and oisy-wallet-signer and are also used by the community—such as myself in Juno. To avoid code duplication, it might be beneficial to create a library for these schemas related to building apps on the IC.
Notes
The package contains a dummy test to be removed as the CI requires at least a test to complete.
Changes
@dfinity/zod-schemasand tooling without any logic.