Skip to content

Commit

Permalink
fix(IDX): skip build determinism if files were not rebuilt (#3852)
Browse files Browse the repository at this point in the history
This implements a workaround to return successfully from the build
determinism check if no artifacts were built/uploaded.

The correct fix would be to pass the shasums via GHA artifacts. Until
then, we make sure not to fail if the artifacts were not uploaded to S3
(i.e. returning 403).
  • Loading branch information
nmattia authored Feb 7, 2025
1 parent 5a93040 commit f03f9ee
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions ci/scripts/build-determinism.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,14 @@ VERSION="$(git rev-parse HEAD)"

# PATH0
mkdir -p "$PATH0"
curl -sfS --retry 5 --retry-delay 10 \
if ! curl -sfS --retry 5 --retry-delay 10 \
"https://download.dfinity.systems/ic/$VERSION/$PATH0/SHA256SUMS" \
-o "$PATH0/SHA256SUMS"
-o "$PATH0/SHA256SUMS"; then

# workaround until we have a better way to pass SHA256SUMS files around
echo "Assuming artifacts were not rebuilt"
exit 0
fi

# ignore *.wasm.gz.did files (these are checksummed by upload_artifacts but
# not by build-ic.sh)
Expand Down

0 comments on commit f03f9ee

Please sign in to comment.