Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CRP-2641 CRP-2615 Add vetKeys related management canister endpoints #2633

Merged
merged 8 commits into from
Nov 19, 2024

Conversation

eichhorl
Copy link
Contributor

@eichhorl eichhorl commented Nov 15, 2024

This PR defines names and arguments of the new functions:

  • ReshareChainKey
  • VetKdPublicKey
  • VetKdEncryptedKey

A corresponding interface spec PR can be found here. For now, all functions remain unimplemented.

In addition, we implement routing of these methods by calling route_idkg_message with the correct MasterPublicKeyId. This function will be renamed and tested for the vet KD case in a follow up PR.

@github-actions github-actions bot added the feat label Nov 15, 2024
@eichhorl eichhorl changed the title feat: ic00 vetkd feat: CRP-2641 CRP-2615 Add vetKeys related management canister endpoints Nov 18, 2024
@eichhorl eichhorl self-assigned this Nov 18, 2024
@eichhorl eichhorl marked this pull request as ready for review November 18, 2024 10:11
@eichhorl eichhorl requested review from a team as code owners November 18, 2024 10:11
@eichhorl eichhorl requested a review from fspreiss November 18, 2024 10:11
Copy link
Member

@fspreiss fspreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @eichhorl! Looks very good to me, modulo some minor renamings.

rs/types/management_canister_types/src/lib.rs Outdated Show resolved Hide resolved
rs/types/management_canister_types/src/lib.rs Show resolved Hide resolved
rs/types/management_canister_types/src/lib.rs Outdated Show resolved Hide resolved
rs/types/management_canister_types/src/lib.rs Outdated Show resolved Hide resolved
rs/types/management_canister_types/src/lib.rs Outdated Show resolved Hide resolved
rs/types/management_canister_types/src/lib.rs Show resolved Hide resolved
@eichhorl eichhorl requested a review from fspreiss November 18, 2024 17:21
@eichhorl
Copy link
Contributor Author

eichhorl commented Nov 18, 2024

Thanks a lot, @eichhorl! Looks very good to me, modulo some minor renamings.

Thanks for the review @fspreiss! I think I addressed all of the naming problems

Copy link
Member

@fspreiss fspreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments, @eichhorl!

@eichhorl eichhorl added this pull request to the merge queue Nov 19, 2024
Merged via the queue into master with commit caca44d Nov 19, 2024
26 checks passed
@eichhorl eichhorl deleted the eichhorl/ic00-vetkd branch November 19, 2024 09:10
DFINITYManu pushed a commit that referenced this pull request Nov 19, 2024
…ints (#2633)

This PR defines names and arguments of the new functions:

- ReshareChainKey
- VetKdPublicKey
- VetKdEncryptedKey

A corresponding interface spec PR can be found
[here](dfinity/portal#3763). For now, all
functions remain unimplemented.

In addition, we implement routing of these methods by calling
`route_idkg_message` with the correct `MasterPublicKeyId`. This function
will be renamed and tested for the vet KD case in a follow up PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants