Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bitcoin crate upgrade #3080

Merged
merged 63 commits into from
Jan 23, 2025
Merged

Conversation

mihailjianu1
Copy link
Contributor

@mihailjianu1 mihailjianu1 commented Dec 10, 2024

Upgrade the bitcoin crate almost everywhere.

Some test targets in the crypto crate have not been upgraded yet. The main issue there is that we can't have the secp256k1 dependency (transitive) on different versions from different dependencies with bazel. See more on why here: #1150.

The latest bitcoin dependency depends on secp256k1 0.29, however the latest bip32 dependency has not upgraded to 0.29 yet. The best course of action would be to separate these crates, however to unblock the testnet4 support, that can be done at a later date.

The ckBTC minter canister has also not been upgraded

@github-actions github-actions bot added the fix label Dec 13, 2024
@mihailjianu1 mihailjianu1 changed the title fix: bitcoin crate upgrade chore: bitcoin crate upgrade Dec 16, 2024
@github-actions github-actions bot added chore and removed fix labels Dec 16, 2024
@mihailjianu1 mihailjianu1 added this pull request to the merge queue Jan 23, 2025
Merged via the queue into master with commit 967fe21 Jan 23, 2025
26 checks passed
@mihailjianu1 mihailjianu1 deleted the mihailjianu1/bitcoin-crate-upgrade branch January 23, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants