-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add best effort messages to random traffic canister #3108
Merged
stiegerc
merged 57 commits into
master
from
add_best_effort_msgs_to_random_traffic_canister
Jan 23, 2025
Merged
test: Add best effort messages to random traffic canister #3108
stiegerc
merged 57 commits into
master
from
add_best_effort_msgs_to_random_traffic_canister
Jan 23, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sgs_to_random_traffic_canister
…sgs_to_random_traffic_canister
…hub.com:dfinity/ic into add_best_effort_msgs_to_random_traffic_canister
…sgs_to_random_traffic_canister
berestovskyy
approved these changes
Jan 13, 2025
…sgs_to_random_traffic_canister
…hub.com:dfinity/ic into add_best_effort_msgs_to_random_traffic_canister
…sgs_to_random_traffic_canister
…sgs_to_random_traffic_canister
marko-k0
approved these changes
Jan 22, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 23, 2025
The next version of `cdk-rs` [requires](https://github.com/dfinity/cdk-rs/blob/next/Cargo.toml#L36) a newer version of `Candid`. The development branch `next` of `cdk-rs` has to be used in order to [test](#3108) best-effort messages before the new messaging model can be rolled out.
…sgs_to_random_traffic_canister
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 23, 2025
…sgs_to_random_traffic_canister
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Jan 23, 2025
…sgs_to_random_traffic_canister
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for best-effort calls on the random traffic canister. All arguments used to run the canister are collected in the
Config
now (except the random seed) since otherwise the number of update calls and individual parameters would get quite large.Adds a new test where a local canister makes only best-effort calls, to itself and to a remote subnet. Checks that the local canister can be stopped even if the remote subnet stalls.
To change any parameter you can query the current config, then change it accordingly and send it back to the canister. The seed is excluded since reseeding the rng every time would reset the random sequence.
Additionally the records now contain a timeout if the call is best-effort and the time from making the call to receiving a reply is measured (for all calls).