Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add best effort messages to random traffic canister #3108

Merged
merged 57 commits into from
Jan 23, 2025

Conversation

stiegerc
Copy link
Contributor

@stiegerc stiegerc commented Dec 11, 2024

Adds support for best-effort calls on the random traffic canister. All arguments used to run the canister are collected in the Config now (except the random seed) since otherwise the number of update calls and individual parameters would get quite large.
Adds a new test where a local canister makes only best-effort calls, to itself and to a remote subnet. Checks that the local canister can be stopped even if the remote subnet stalls.

To change any parameter you can query the current config, then change it accordingly and send it back to the canister. The seed is excluded since reseeding the rng every time would reset the random sequence.

Additionally the records now contain a timeout if the call is best-effort and the time from making the call to receiving a reply is measured (for all calls).

@github-actions github-actions bot added the test label Dec 11, 2024
@stiegerc stiegerc marked this pull request as ready for review January 13, 2025 10:41
@stiegerc stiegerc requested review from a team as code owners January 13, 2025 10:41
rs/messaging/tests/memory_tests.rs Outdated Show resolved Hide resolved
rs/config/src/embedders.rs Outdated Show resolved Hide resolved
@stiegerc stiegerc requested a review from a team as a code owner January 22, 2025 13:47
github-merge-queue bot pushed a commit that referenced this pull request Jan 23, 2025
The next version of `cdk-rs`
[requires](https://github.com/dfinity/cdk-rs/blob/next/Cargo.toml#L36) a
newer version of `Candid`. The development branch `next` of `cdk-rs` has
to be used in order to [test](#3108)
best-effort messages before the new messaging model can be rolled out.
@stiegerc stiegerc added this pull request to the merge queue Jan 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 23, 2025
@stiegerc stiegerc added this pull request to the merge queue Jan 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jan 23, 2025
@stiegerc stiegerc added this pull request to the merge queue Jan 23, 2025
Merged via the queue into master with commit ca3b684 Jan 23, 2025
25 checks passed
@stiegerc stiegerc deleted the add_best_effort_msgs_to_random_traffic_canister branch January 23, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants