fix: bind to [::1] per default instead of 127.0.0.1 in PocketIC #3280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraszyk
added
the
CI_MACOS_INTEL
michael-weigelt
approved these changes
Jan 23, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
…ocketIC (#3280)" (#3597) Reverting this [PR](#3280) since the flakiness [persists](https://github.com/dfinity/ic/actions/runs/12948633271/job/36117683459?pr=3595).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the PocketIC server and HTTP gateway bind to [::1] per default instead of 127.0.0.1 to work around an issue with macOS sandbox spuriously preventing binding to 127.0.0.1. Because
fqdn!panics with [::1],FQDN::from_stris now used instead.