chore(ckbtc): Remove empty ReceivedUtxos events from event log #3434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninegua
added
the
CI_ALL_BAZEL_TARGETS
…y-utxos-event-log
There was a problem hiding this comment.
Thanks @ninegua for this PR! Generally looks good to me, just some minor question/comments
There was a problem hiding this comment.
Thanks @ninegua for the changes! To me the changes look good! There is one open comment left related how to ensure that we can indeed do the migration within the post_upgrade (and not run into the instruction limit for example).
gregorydemay
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XC-239: ckBTC minter: Clean-up event logs
For historical reasons, ckBTC mainnet canister has a lot of ReceivedUtxos with empty Utxos, which is removed by this PR.