-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: [EXC-1835] Move ic_management_types in its own crate #3438
Draft
michael-weigelt
wants to merge
35
commits into
master
Choose a base branch
from
mwe/mgmt
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,022
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* New crate ic-management * tuple * raw_rand * assert * create_canister * separate test files * update_settings * install_code (just begin) * minimal wasm * cleanup * more methods * canister_status * more * http_request (Not tested yet) * ignore test * bitcoin * remove http_request test, restructure * threshold_ecdsa * reply * provisional * provisional * restructure * e2e provisional * try e2e threshold_ecdsa * mod * mv * fix * remove crate * remove crate * fix * Fix http types * pay for create_canister * Pay for http_request * deposit cycles * rename HttpResponse * vis * remove impossible tests * Fix bitcoin * management canister example test * rm management canister e2e test * Revert change of e2e * revert * rm * fix * try fix * try * try again * dfx 0.11.1 * fix * doc main * doc main types * doc provisional * doc http_request * fmt * doc ecdsa * rename ecdsa * Response * doc bitcoin * fix test * changelog * rename_all * derive traits as many as possible * patch all examples * fix
* Update http_request transform type. * update changelog * fix tests * import candid * fix management_canister and test * simplify examples * changelog * ctor * from_transform_function * fix doc Co-authored-by: Linwei Shang <[email protected]>
* feat: specify cycles when create canister * bump and changelog * fmt
…with context. (#326) * Update for HTTPS Outcalls transform function with context. * fix errors * another fix * working * update changelog * fix test * bump dfx for examples * changelog Co-authored-by: Linwei Shang <[email protected]>
This PR removes ic-cdk-macros's dependency on ic-cdk, which was only used for an intra-doc link and the reexported `Principal` more easily accessed from Candid. This enables ic-cdk to depend on ic-cdk-macros and reexport its macros; with this change, users no longer need to declare two dependencies for the full CDK.
* fix docs * bump and changelog * remove chess frontend * update ic rev * date
* Overhaul executor * Update changelog * Remove all the implementation details from the documentation * Update the docs for the new lints * Update the Rust version elsewhere * Add PR number to changelog * lint * Fix a comment * Additions * that doesn't work
* Add http_request_with_cycles and doc * changelog * clone * remove missing_doc lint for ic0
* chore: Improve doc comments for max_response_bytes * Add link to documentation --------- Co-authored-by: Linwei Shang <[email protected]>
* Implement closure-based HTTP transform API * Update ic0.rs for warnings * Update changelog * Update example * doc lint * Update example to include captured context * Add separate constructor function to TransformContext * Rename crate feature and document `transform` field * Update src/ic-cdk/src/api/management_canister/http_request.rs Co-authored-by: Linwei Shang <[email protected]> * Update src/ic-cdk/src/api/management_canister/http_request.rs Co-authored-by: Linwei Shang <[email protected]> * Better assertion message --------- Co-authored-by: Linwei Shang <[email protected]>
* Fix doc build * Bump version
* set sender_canister_version and support canister_info * use canister_info in test canister * remove Canister from CanisterChangeOrigin and CanisterChangeDetails variant types
* btc API fees * ecdsa fees * create canister fee * mv * split http_request * http_request fee * tests * doc * bump ver & changelog
* bitcoin fee * bump ver & changelog
* enhancements to bitcoin and ecdsa * cargo fmt * add back bitcoin prefix * bump ver and changelog * doc * fix example * fmt --------- Co-authored-by: Linwei Shang <[email protected]>
* feat(breaking): bump CDK to use candid 0.9-beta (#367) * bump CDK to use candid 0.9-beta * make ic-ledger-types not breaking * chore: release continue (#370) * fix * bump ver * Add readme to ic-cdk-timers --------- Co-authored-by: Adam Spofford <[email protected]> * version and changelog * fix chess * disable examples using import --------- Co-authored-by: Linwei Shang <[email protected]> Co-authored-by: Adam Spofford <[email protected]> * test * add wasmtime in CI * revert * use patched ic-test-state-machine-client * feat: ic-cdk-bindgen replace import macro (#390) * import did file * fix * test * fix counter example * rename to ic-cdk-bindgen * fix profile example * no re-export * enable all example tests in CI * remove import and fix tests * fix clippy * fix ic-certified-map doc test * fmt --------- Co-authored-by: Linwei Shang <[email protected]> * feat: add export_candid macro (#386) * export candid * fix build.sh * actor macro * add wasmtime in CI * fix * fix * fix * remove actor macro * fix * ic-cdk/wasi enables export_candid * git forget declarations/ * fmt * Warning features in Cargo.toml * bump ic0 version --------- Co-authored-by: Linwei Shang <[email protected]> * prepare for release * TODO comment * changelog * doc export_candid * format changelog * bump library and changelog * explain why no doc for TransformFunc * find solution for doc TransformFunc * remove TODO * doc hidden wasi mod --------- Co-authored-by: Yan Chen <[email protected]> Co-authored-by: Adam Spofford <[email protected]> Co-authored-by: Yan Chen <[email protected]>
* Added query stats to canister status endpoint * Changelog * pub and doc * update ic-state-machine * Adopt new API as discussed with Martin * bump ic-cdk v0.11.4 --------- Co-authored-by: Linwei Shang <[email protected]>
* feat: Add `reserved_cycles` and `reserved_cycles_limit` This adds the new fields to the API of the management canister: - `reserved_cycles` to `CanisterStatusResponse`. - `reserved_cycles_limit` to `CanisterSettings` and `DefiniteCanisterSettings`. More information: - https://forum.dfinity.org/t/23447 - https://dashboard.internetcomputer.org/proposal/126094 * Add to CHANGELOG and fix errors * changelog details --------- Co-authored-by: Linwei Shang <[email protected]>
* feat: config canister endpoint decoding quota * add call_with_config * fix * fix * changelog * fix * fix * update changelog
…store (#461) * feat: add management canister methods for interacting with the chunk store * Update CHANGELOG * fmt * IC spec change * Serialize with `serde_bytes` * fix: names * test: e2e chunk * chore: upgrade state-machine binary * chore: cargo fmt & clippy * fix: clippy * fix: make the tests pass * conform final spec --------- Co-authored-by: Linwei Shang <[email protected]>
* feat: Add `wasm_memory_limit` to the management canister This adds `wasm_memory_limit` to `CanisterSettings` and `DefiniteCanisterSettings`. The corresponding spec change: - dfinity/interface-spec#278 * Add the PR number to the change log * unify doc format * better test coverage --------- Co-authored-by: Linwei Shang <[email protected]>
* upgrade syn to v2 * move macros doc to ic-cdk for doc-tests * fix doc links * ci: add doc step which fail on warnings * fix cache key * bump dependency if major outdated
* snapshot types * snapshot methods * types cont. * update pocket-ic which support nonmainnet features * e2e test * add LoadSnapshot variant to CanisterChangeDetails * changelog * fix canister_info e2e test * show canister_info after snapshot operations * ci test show output * revert canister_info.rs * revert ci.yml * canister_info changes can have load_snapshot records
Co-authored-by: Severin Siffert <[email protected]>
* feat: support subnet_info * changelog * use ubuntu-24.04 in CI * clippy * fix(e2e): create canister requires more cycles * rust 1.78.0
michael-weigelt
changed the title
chore: Move ic_management_types in its own crate
chore: [EXC-1835] Move ic_management_types in its own crate
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://docs.google.com/document/d/1xvE480Tf61SaJc0AP74_4WDbh01alBU2aQHIRwx3XMw/edit?tab=t.0